Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for modifying the tick rate #6592

Open
wants to merge 45 commits into
base: dev/feature
Choose a base branch
from
Open

Adds support for modifying the tick rate #6592

wants to merge 45 commits into from

Conversation

Asleeepp
Copy link
Contributor

Description

This PR aims to add support for the tick rate to be changed, modified, etc, etc
Currently unfinished.
Plans to add a lot more to this.

Target Minecraft Versions: 1.20.3+
Requirements: none
Related Issues: none

@Asleeepp Asleeepp marked this pull request as draft April 19, 2024 17:32
@AyhamAl-Ali AyhamAl-Ali added the feature Pull request adding a new feature. label Apr 19, 2024
@sovdeeth sovdeeth changed the base branch from master to dev/feature April 19, 2024 21:14
@Asleeepp Asleeepp marked this pull request as ready for review April 21, 2024 12:35
sovdeeth
sovdeeth requested changes Apr 21, 2024
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs tests for the parts that can be tested. (probably can't test stepping, maybe with junit)

src/main/java/ch/njol/skript/conditions/CondEntityFrozen.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondEntityFrozen.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondEntityFrozen.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondEntityFrozen.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondEntityFrozen.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprTick.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprTick.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprTick.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprTick.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprTick.java Outdated Show resolved Hide resolved
@Asleeepp Asleeepp requested a review from sovdeeth April 22, 2024 19:02
sovdeeth
sovdeeth requested changes Apr 23, 2024
View reviewed changes
src/main/java/ch/njol/skript/conditions/CondIsTickFrozen.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondServerTickState.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondServerTickState.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondServerTickState.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffFreezeServer.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprFrozenTicksToRun.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprTick.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprFrozenTicksToRun.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprTick.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprTick.java Outdated Show resolved Hide resolved
@Asleeepp Asleeepp requested review from sovdeeth and Moderocky April 26, 2024 18:49
APickledWalrus
APickledWalrus requested changes Jun 27, 2024
View reviewed changes
src/main/java/ch/njol/skript/conditions/CondServerTickState.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondServerTickState.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffSprintServer.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondServerTickState.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffStepServer.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprFrozenTicksToRun.java Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprFrozenTicksToRun.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprServerTickRate.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffStepServer.java Outdated Show resolved Hide resolved
@Asleeepp Asleeepp requested a review from APickledWalrus June 28, 2024 19:52
@sovdeeth sovdeeth added the 2.9 Targeting a 2.9.X version release label Jun 29, 2024
@APickledWalrus APickledWalrus removed the 2.9 Targeting a 2.9.X version release label Jul 2, 2024
UnderscoreTud
UnderscoreTud requested changes Aug 19, 2024
View reviewed changes
src/main/java/ch/njol/skript/conditions/CondServerTickState.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondServerTickState.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondServerTickState.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffFreezeServer.java Show resolved Hide resolved
src/main/java/ch/njol/skript/conditions/CondServerTickState.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffStepServer.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprFrozenTicksToRun.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprFrozenTicksToRun.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprFrozenTicksToRun.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprServerTickRate.java Show resolved Hide resolved
@TheAbsolutionism
Copy link
Contributor

#6314

APickledWalrus
APickledWalrus requested changes Nov 22, 2024
View reviewed changes
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great candidate to be a Module (something like org.skriptlang.skript.bukkit.ticking). I'm happy to walk you through it.

Test failures will need to be addressed (it appears to be caused by the delays/wait effect is all). Re-request for approval 🙂

src/main/java/ch/njol/skript/conditions/CondServerTickState.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffSprintServer.java Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffStepServer.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprFrozenTicksToRun.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprServerTickRate.java Outdated Show resolved Hide resolved
Asleeepp and others added 3 commits November 22, 2024 19:56
@Asleeepp
Merge branch 'dev/feature' into addition-modify-tick
02897e4
@Asleeepp @APickledWalrus
Apply suggestions from code review
fc81783 
Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
@Asleeepp @APickledWalrus
Apply suggestions from code review
e3d2e79 
Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
@APickledWalrus APickledWalrus self-requested a review December 19, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Moderocky Moderocky Moderocky approved these changes

@UnderscoreTud UnderscoreTud Awaiting requested review from UnderscoreTud

@APickledWalrus APickledWalrus Awaiting requested review from APickledWalrus

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
feature Pull request adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Asleeepp @TheAbsolutionism @sovdeeth @Moderocky @APickledWalrus @UnderscoreTud @AyhamAl-Ali