Added armorstand pose expression and test #6827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
requested changes
Jun 28, 2024
There was a problem hiding this comment.
I'm not a big fan of how this is implemented. To my knowledge, converting an euler angle to a single directional vector loses the entire roll axis, which is pretty important to have. I would rather see this implemented with either
a) a yaw, pitch, roll inputs
b) a direction + roll input
I'd prefer the first but i see how the second could be more versatile, and of course, both can also be useful.
sovdeeth
added
feature
|
I'm going on vacation tomorrow but i can implement support for roll when i get home. |
|
could you also seperate the pattern please? it makes it easier to read on the docs. you could probably group similar things like left/right arm still |
|
@TFSMads Do you intend to continue this PR? |
|
Closing due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added armorstand pose expression and a test for the expression.
Target Minecraft Versions: any
Requirements: none
Related Issues: #6597