Exposes 'load default aliases' config option and removes hardcoded alias dependencies #6834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'load deafult aliases' config option
sovdeeth
added
bug
APickledWalrus
requested changes
Jun 30, 2024
src/main/java/ch/njol/skript/bukkitutil/block/NewBlockCompat.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
…Skript into feature/expose-aliases
Moderocky
approved these changes
Jul 1, 2024
Closed
APickledWalrus
approved these changes
Jul 1, 2024
Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
sovdeeth
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes are aimed around giving users the ability to disable aliases they don't want to use, via disabling the default ones and using just the alias folder instead.
Skript had hard dependencies on many aliases that have now been replaced with Materials or Tag references.
This also fixes some issues with torch placement in 1.19+, as well as a bug with the block setter's flags always being true, and makes sure aliases are always generated for all Materials.
Target Minecraft Versions: any
Requirements: none
Related Issues: none