Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ItemData#equals check #6888

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Fix ItemData#equals check #6888

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e14bf5
Use proper isAlias check in ItemData#equals
APickledWalrus Jul 10, 2024
ca4d61e
Add a simple EffEquip test
APickledWalrus Jul 12, 2024
373593d
Merge branch 'dev/feature' into patch/is-of-type-comparison-issue
APickledWalrus Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/ch/njol/skript/aliases/ItemData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ public boolean equals(final @Nullable Object obj) {
return false;

ItemData other = (ItemData) obj;
if (isAlias) { // This is alias, other item might not be
if (isAlias()) { // This is alias, other item might not be
return other.matchAlias(this).isAtLeast(MatchQuality.SAME_ITEM);
} else { // This is not alias, but other might be
return matchAlias(other).isAtLeast(MatchQuality.SAME_ITEM);
Expand Down