Runtime errors #7155
Open
Runtime errors #7155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
requested changes
Dec 16, 2024
src/main/java/org/skriptlang/skript/lang/errors/RuntimeErrorProducer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/lang/errors/RuntimeErrorManager.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/lang/errors/RuntimeErrorManager.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/lang/errors/RuntimeErrorManager.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/lang/errors/RuntimeErrorManager.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/lang/errors/RuntimeErrorProducer.java
Outdated
Show resolved
Hide resolved
Switch to REConsumer, create RE and ErrorSource classes, use new config reload event.
APickledWalrus
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Looking really good with these changes.
I think this is looking really good. My main concern is with how the strings are being passed/formatted around. Do you think we would be able to move some of this Bukkit-specific formatting stuff into the consumers? For example, when appending to timeoutTexts, don't call Utils#replaceEnglishChatStyles on the string there and instead call it within the consumer
src/main/java/org/skriptlang/skript/log/runtime/RuntimeError.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/log/runtime/RuntimeErrorManager.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/log/runtime/RuntimeErrorManager.java
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/log/runtime/RuntimeError.java
Outdated
Show resolved
Hide resolved
Moderocky
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates a RuntimeErrorProvider interface that SyntaxElements can implement in order to throw runtime errors and warnings.
Out of scope, for future PRs:
Target Minecraft Versions: any
Requirements: none
Related Issues: none