Inventory - prevent opening a non-creatable inventory #7279
+37
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Efnilite
approved these changes
Dec 18, 2024
Efnilite
added
bug
sovdeeth
approved these changes
Dec 18, 2024
Efnilite
added
the
feature-ready
|
could we please get a regression test |
Done 👍🏻 |
Pikachu920
approved these changes
Dec 18, 2024
|
I would like to note (for changelog reasons) that this won't completely work on some early versions of 1.19.4 due to spigot having marked non-createable invs as createable, but it was fixed about 5days after updating to 1.19.4 so not worth addressing imo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix a bug when trying to create/open an inventory that Bukkit doesn't want us to
Target Minecraft Versions: any
Requirements: none
Related Issues: #7278