ENH: Add detached vtkIECTransformLogic library to SlicerRT superbuild #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit was authored by TrosnyogoSzakoca. I just rebased it to current tip of master branch. -Change existing code to use new library instead of vtkSlicerIECTransformLogic -Delete old vtkSlicerIECTransformLogic -Add new external cmake to superbuild folder -Update CMakeLists -Main problem: dll not found errors during SlicerRT startup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cpinter
These commits were authored by @TrosnyogoSzakoca. I just tried rebasing it to current tip of master branch trying to fix merge conflicts due to the recent bugfixes by @MichaelColonel (thanks!!).
This should not be merged yet, as according to Mark, there are some problem with finding dlls in Windows (and on my side on Linux it runs well, but I have some issues with include paths in Linux when operated as standalone).
Comments/ideas are welcome.