Improve VRM model file input #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abb128
requested review from
ButterscotchV,
Eirenliel,
Erimelowo,
ImUrX and
loucass003
as code owners
github-actions
bot
added
Area: GUI
ButterscotchV
approved these changes
Nov 21, 2024
Eirenliel
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't like how the current one looks, it's not immediately clear what model is loaded or not, the text looked like part of the description
Old unloaded and loaded
New unloaded and loaded
The added X lets you unset the model. There is no functional use to unsetting the VRM model, but it generally helps with UX to allow users to undo their actions and it also serves to remind about drag and drop. This should replace #948