Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled nether portals in galactifun worlds #160

Merged
merged 12 commits into from
Jul 9, 2024
Merged

Disabled nether portals in galactifun worlds #160

merged 12 commits into from
Jul 9, 2024

Conversation

IvanMishin1
Copy link
Contributor

@IvanMishin1 IvanMishin1 commented Jul 9, 2024 •
edited
Loading

Changes

  • Disabled creating and using nether portals in galactifun worlds
  • Added an option to enable creating and using nether portals in galactifun worlds (false by default)

Checklist

  • I have fully tested the proposed changes and promise that they will not break world generation, mob spawning, and the like.
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values

@IvanMishin1 IvanMishin1 marked this pull request as ready for review July 9, 2024 19:49
@IvanMishin1 IvanMishin1 requested a review from a team as a code owner July 9, 2024 19:49
IvanMishin1 and others added 3 commits July 9, 2024 22:04
@IvanMishin1 @Seggan
Update src/main/java/io/github/addoncommunity/galactifun/core/manager…
e6e8af8 
…s/WorldManager.java

Co-authored-by: Seggan <seggan21@gmail.com>
@IvanMishin1 @Seggan
Update src/main/java/io/github/addoncommunity/galactifun/core/manager…
3291570 
…s/WorldManager.java

Co-authored-by: Seggan <seggan21@gmail.com>
@IvanMishin1
Added getFrom()
9d2b4e3
@IvanMishin1 IvanMishin1 requested a review from Seggan July 9, 2024 20:12
@Seggan
Copy link
Member

Seggan commented Jul 9, 2024

Thank you for your contribution

@Seggan Seggan merged commit c598c22 into Slimefun-Addon-Community:master Jul 9, 2024
1 check passed
@IvanMishin1 IvanMishin1 deleted the portal-pull branch July 9, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seggan Seggan Seggan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IvanMishin1 @Seggan