Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/flint and steal unbreaking #4247

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Intybyte
Copy link
Contributor

Description

Make the Automatic Ignition chamber respect the level of the Unbreaking enchantment on the tool selected for durability loss (thus, an Unbreaking 3 Flint and Steel would last 4 times as long on average).

Proposed changes

Refactor the code releated to damaging the flint and steal into a damageFlintAndSteel method that uses vanilla MC unbreaking calculation to determine when to damage the flint and steal

Related Issues (if applicable)

Suggestion 2429 #approved

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@Intybyte Intybyte requested a review from a team as a code owner September 26, 2024 11:03
Copy link
Contributor

Your Pull Request was automatically labelled as: "🎈 Feature"
Thank you for contributing to this project! ❤️

@github-actions github-actions bot added the 🎈 Feature This Pull Request adds a new feature. label Sep 26, 2024
Copy link
Contributor

github-actions bot commented Sep 26, 2024

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 5a82316

https://preview-builds.walshy.dev/download/Slimefun/4247/5a823160

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

Intybyte and others added 4 commits October 26, 2024 17:54
…n/items/blocks/IgnitionChamber.java

Co-authored-by: JustAHuman-xD <65748158+JustAHuman-xD@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎈 Feature This Pull Request adds a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants