Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Adding fine-tuning options for the autocompletion #3487

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

rbayet
Copy link
Collaborator

@rbayet rbayet commented Jan 14, 2025

Replaces #3467 (rebased with conflicts resolved)

@rbayet rbayet marked this pull request as ready for review January 14, 2025 17:47
@rbayet rbayet added the safe to test PR can be tested label Jan 14, 2025
@romainruaud
Copy link
Collaborator

romainruaud commented Jan 15, 2025

So, I added 2 commits :

  • the first one to ensure the "size of search terms to use", aka extension_size must be >0
  • the second one to rename the extension_limit to extension_limited because it's a boolean which defines if the extension mechanism must be limited or not.

@romainruaud romainruaud assigned rbayet and unassigned romainruaud Jan 15, 2025
src/module-elasticsuite-core/etc/adminhtml/system.xml Outdated Show resolved Hide resolved
src/module-elasticsuite-core/etc/adminhtml/system.xml Outdated Show resolved Hide resolved
src/module-elasticsuite-core/etc/adminhtml/system.xml Outdated Show resolved Hide resolved
src/module-elasticsuite-core/etc/adminhtml/system.xml Outdated Show resolved Hide resolved
src/module-elasticsuite-core/etc/adminhtml/system.xml Outdated Show resolved Hide resolved
src/module-elasticsuite-core/etc/adminhtml/system.xml Outdated Show resolved Hide resolved
src/module-elasticsuite-core/etc/adminhtml/system.xml Outdated Show resolved Hide resolved
src/module-elasticsuite-core/etc/adminhtml/system.xml Outdated Show resolved Hide resolved
@rbayet rbayet assigned romainruaud and unassigned rbayet Jan 16, 2025
@rbayet rbayet force-pushed the feature-autocomplete-extension-rebase branch from 43c2f3d to 98aaeb0 Compare January 17, 2025 16:31
@rbayet rbayet merged commit 492a35a into 2.10.x Jan 17, 2025
9 checks passed
@rbayet rbayet deleted the feature-autocomplete-extension-rebase branch January 17, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants