Add sergeant role (second LEO supervisor) #1949
Conversation
|
Nice PR, though, what's the point if they can use custom roles instead 👀? |
This appears to be related to my issue here and permissions: The need for another Supervisor option is important for lower level Supervisor so they don't have as much power. (In case someone gets terminated from a Department and then tries to sabotage officers) |
|
So ultimately another role isn't whats needed (as this can be achieved with custom roles), but additional permission keys so you can split out the "Manage Units" key into less privileged tasks such as the ones you listed?
|
|
Yes exactly Basically so we can fine tune a few more permissions as needed for security reasons |
|
Does this one just need to be merged with next update then its good to go basically? |
|
I don't think this PR is effective in resolving the issue raised, we need additional permission keys, not more static roles that people can replicate already with custom roles. Perhaps Casper can comment on this and potentially look to add more segregation to the manage unit permissions. |
|
I also realized just now that Manage Officer Rank (to change an officer's rank) is not an option under Custom Roles as a Permission to select. |
@casperiv0 I think we can close this one now because this method is easier now: #1956 |
|
Superseded by #1956 |
Feature
closes: #numberTranslations
.jsonfiles are formatted:pnpm formati18n.config.mjscloses #1922