Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pandas support #388

Merged
merged 3 commits into from
Feb 6, 2024
Merged

fix pandas support #388

merged 3 commits into from
Feb 6, 2024

Conversation

jeppe742
Copy link
Contributor

@jeppe742 jeppe742 commented Feb 6, 2024

pandas 2.2 doesn't support SQLAlchemy <2.0 anymore

pandas-dev/pandas#57049

Copy link

github-actions bot commented Feb 6, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
adapta/connectors/service_bus
   __init__.py110%18
   _connector.py17170%19–61
adapta/logs
   _base.py853262%89–92, 199–201, 213–215, 256–288
   _internal.py14286%84–90
adapta/logs/handlers
   datadog_api_handler.py1093172%89, 106–113, 124, 136–152, 161–194, 203, 209, 237
adapta/metrics/providers
   datadog_provider.py37370%19–122
adapta/ml
   __init__.py110%19
   _model.py10100%17–42
adapta/ml/mlflow
   __init__.py220%17–18
   _client.py42420%19–142
   _functions.py42420%17–111
adapta/process_communication
   _models.py32681%89–95
adapta/security/clients
   __init__.py261254%27–28, 34–35, 41–42, 48–49, 53–54, 58–59
   _azure_client.py714931%42, 55–64, 74–77, 80, 83–85, 94–152, 155, 158–196
adapta/security/clients/aws
   _aws_client.py28968%36–37, 44, 54, 61, 68, 83, 89–94
   _aws_credentials.py461861%49–59, 63, 67, 71, 80–82, 86, 90, 94
adapta/security/clients/hashicorp_vault
   hashicorp_vault_client.py28389%46, 83, 87
   kubernetes_client.py21576%45–48, 67–68
   oidc_client.py452056%33–62, 80–83, 92
   token_client.py17759%42–45, 52–53, 56, 59
adapta/storage
   exceptions.py110%22
adapta/storage/blob
   azure_storage_client.py1145056%70–77, 86–87, 90–96, 118–119, 122–148, 151, 167–180, 188–192, 211, 232–234, 243, 259–263, 273–275, 278–297
   s3_storage_client.py47470%19–150
adapta/storage/cache
   redis_cache.py37370%19–107
adapta/storage/database
   azure_sql.py322038%55, 70, 84–122, 132
   odbc.py711185%93–103, 113, 124–125, 139, 145–151, 177
   snowflake_sql.py33330%4–93
   trino_sql.py37370%20–119
adapta/storage/delta_lake
   _functions.py611182%139, 144, 146, 148, 205, 215, 225–235, 241, 272
adapta/storage/distributed_object_store/datastax_astra
   _models.py19953%38–43, 46, 49, 52
   astra_client.py18313128%38–41, 110–128, 134–177, 180–181, 191, 203–204, 213, 251–338, 346, 368–481, 491, 501–516, 535–548, 568–584, 606–623
adapta/storage/models
   astra.py32875%36, 39, 43, 57, 60, 66–69
   aws.py28679%35, 41, 48, 74, 84–86
   azure.py601772%32, 36–40, 47, 67, 70–71, 74–75, 89–93, 100, 113, 120, 123–124, 127
   filter_expression.py125596%55, 183–184, 238, 329
   hive.py572556%36, 40, 43, 91–98, 110, 113–114, 123–163, 166
   local.py21481%31, 35, 38, 50
adapta/storage/query_enabled_store
   _models.py591280%64, 71, 77, 125–128, 134–137, 143–144, 150
   _qes_astra.py44686%68–78, 87–94
   _qes_delta.py30390%28, 57, 65
adapta/storage/secrets
   azure_secret_client.py20200%19–66
adapta/utils
   _common.py841385%66–79, 90, 118, 138, 158, 215
   concurrent_task_runner.py27196%109
adapta/utils/data_structures
   _functions.py30197%120
adapta/utils/decorators
   _logging.py41198%32
   _rate_limit.py25196%58
tests
   test_filtering_api.py32294%197–198
   test_utils.py149199%336
   test_vault_client.py801878%33–35, 40–42, 47–51, 56–57, 62–66
TOTAL311387772% 

Tests Skipped Failures Errors Time
168 5 💤 0 ❌ 0 🔥 54.988s ⏱️

Copy link

github-actions bot commented Feb 6, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
adapta/connectors/service_bus
   __init__.py110%18
   _connector.py17170%19–61
adapta/logs
   _base.py853262%89–92, 199–201, 213–215, 256–288
   _internal.py14286%84–90
adapta/logs/handlers
   datadog_api_handler.py1093172%89, 106–113, 124, 136–152, 161–194, 203, 209, 237
adapta/metrics/providers
   datadog_provider.py37370%19–122
adapta/ml
   __init__.py110%19
   _model.py10100%17–42
adapta/ml/mlflow
   __init__.py220%17–18
   _client.py42420%19–142
   _functions.py42420%17–111
adapta/process_communication
   _models.py32681%89–95
adapta/security/clients
   __init__.py261254%27–28, 34–35, 41–42, 48–49, 53–54, 58–59
   _azure_client.py714931%42, 55–64, 74–77, 80, 83–85, 94–152, 155, 158–196
adapta/security/clients/aws
   _aws_client.py28968%36–37, 44, 54, 61, 68, 83, 89–94
   _aws_credentials.py461861%49–59, 63, 67, 71, 80–82, 86, 90, 94
adapta/security/clients/hashicorp_vault
   hashicorp_vault_client.py28389%46, 83, 87
   kubernetes_client.py21576%45–48, 67–68
   oidc_client.py452056%33–62, 80–83, 92
   token_client.py17759%42–45, 52–53, 56, 59
adapta/storage
   exceptions.py110%22
adapta/storage/blob
   azure_storage_client.py1134957%70–77, 86–87, 90–96, 118–119, 122–148, 151, 167–180, 188–192, 211, 232–234, 243, 259–263, 273–275, 278–297
   s3_storage_client.py47470%19–150
adapta/storage/cache
   redis_cache.py37370%19–107
adapta/storage/database
   azure_sql.py322038%55, 70, 84–122, 132
   odbc.py711185%93–103, 113, 124–125, 139, 145–151, 177
   snowflake_sql.py33330%4–93
   trino_sql.py37370%20–119
adapta/storage/delta_lake
   _functions.py611182%139, 144, 146, 148, 205, 215, 225–235, 241, 272
adapta/storage/distributed_object_store/datastax_astra
   _models.py19953%38–43, 46, 49, 52
   astra_client.py18313128%38–41, 110–128, 134–177, 180–181, 191, 203–204, 213, 251–338, 346, 368–481, 491, 501–516, 535–548, 568–584, 606–623
adapta/storage/models
   astra.py32875%36, 39, 43, 57, 60, 66–69
   aws.py28679%35, 41, 48, 74, 84–86
   azure.py601772%32, 36–40, 47, 67, 70–71, 74–75, 89–93, 100, 113, 120, 123–124, 127
   filter_expression.py125596%55, 183–184, 238, 329
   hive.py572556%36, 40, 43, 91–98, 110, 113–114, 123–163, 166
   local.py21481%31, 35, 38, 50
adapta/storage/query_enabled_store
   _models.py591280%64, 71, 77, 125–128, 134–137, 143–144, 150
   _qes_astra.py44686%68–78, 87–94
   _qes_delta.py30390%28, 57, 65
adapta/storage/secrets
   azure_secret_client.py20200%19–66
adapta/utils
   _common.py841385%66–79, 90, 118, 138, 158, 215
   concurrent_task_runner.py27196%109
adapta/utils/data_structures
   _functions.py30197%120
adapta/utils/decorators
   _logging.py41198%32
   _rate_limit.py25196%58
tests
   test_filtering_api.py32294%197–198
   test_utils.py149199%336
   test_vault_client.py801878%33–35, 40–42, 47–51, 56–57, 62–66
TOTAL311187672% 

Tests Skipped Failures Errors Time
168 5 💤 0 ❌ 0 🔥 53.792s ⏱️

@jeppe742
Copy link
Contributor Author

jeppe742 commented Feb 6, 2024

create_package

Copy link

github-actions bot commented Feb 6, 2024

Created package with number v2.6.8a388.dev3

Copy link
Contributor

@george-zubrienko george-zubrienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please bump minor for this as it breaks pandas <2.2 clients

pyproject.toml Outdated
@@ -46,7 +46,7 @@ hvac = { version = "~0.11.2", optional = true }

fsspec = { version = "2022.8.2" }

trino = { version = "0.319.0", optional = true, extras = ['sqlalchemy'] }
trino = { version = "0.327.0", optional = true, extras = ['sqlalchemy'] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
trino = { version = "0.327.0", optional = true, extras = ['sqlalchemy'] }
trino = { version = "^0.327.0", optional = true, extras = ['sqlalchemy'] }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember to run poetry update after this

@jeppe742 jeppe742 marked this pull request as ready for review February 6, 2024 09:08
@jeppe742 jeppe742 merged commit 0496879 into main Feb 6, 2024
3 checks passed
@jeppe742 jeppe742 deleted the jjol_fix_pandas_support branch February 6, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants