-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix pandas support #388
fix pandas support #388
Conversation
Coverage Report
|
create_package |
Created package with number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please bump minor for this as it breaks pandas <2.2 clients
pyproject.toml
Outdated
@@ -46,7 +46,7 @@ hvac = { version = "~0.11.2", optional = true } | |||
|
|||
fsspec = { version = "2022.8.2" } | |||
|
|||
trino = { version = "0.319.0", optional = true, extras = ['sqlalchemy'] } | |||
trino = { version = "0.327.0", optional = true, extras = ['sqlalchemy'] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trino = { version = "0.327.0", optional = true, extras = ['sqlalchemy'] } | |
trino = { version = "^0.327.0", optional = true, extras = ['sqlalchemy'] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remember to run poetry update
after this
pandas 2.2 doesn't support SQLAlchemy <2.0 anymore
pandas-dev/pandas#57049