Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for JIT image manipulation recipes #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tmslnz
Copy link

@tmslnz tmslnz commented Jun 16, 2015

When Symphony is configured to only allow image manipulation with Recipes, the extension now honours that setting and generates URLs accordingly.

When Symphony is configured to only allow image manipulation with Recipes, the extension now honours that setting and generates URLs accordingly.
@nitriques
Copy link
Member

Wow! Nice!

But I can't pull that in right now since we need an upgrade path.

Could you:

  1. Create a new version (2.3) in the meta.xml file
  2. Create an upgrade path here

Thanks a lot !

@nitriques nitriques self-assigned this Jun 22, 2015
@tmslnz
Copy link
Author

tmslnz commented Jun 22, 2015

Hi, sure I can try but I’m really not that familiar with Symphony’s API.
Not sure how to add a field to the extension’s schema in the update() function via the API
If you could provide a hint it would be great…

I’m assuming I should be adding the two extra fields that I refer to here? https://github.com/Solutions-Nitriques/image_preview/pull/10/files#diff-dad0e7ecb833ad9a5770ee0636af1052R530

On 22 Jun 2015, at 16:04, Nicolas Brassard notifications@github.com wrote:

Wow! Nice!

But I can't pull that in right now since we need an upgrade path.

Could you:

• Create a new version (2.3) in the meta.xml file
• Create an upgrade path here
Thanks a lot !


Reply to this email directly or view it on GitHub.

@nitriques
Copy link
Member

I’m assuming I should be adding the two extra fields that I refer to here?

Yes.

If you want to learn how, check, this and those

It's essentially what needs to be done.

If you do not want to / can't / whatever, I'll merge the PR manually and do it myself. Thanks again.

@nitriques
Copy link
Member

Ping! Can you please comment ?

@tmslnz
Copy link
Author

tmslnz commented Aug 10, 2015

Whoops, sorry I completely forgot about this. Thanks for the ping! And thanks for the API pointers too!
At the moment I’m a bit pressed with time, so won’t be able to address the required upgrade path changes. Sorry :(
If you are still happy to take care of it yourself might be best. Not lacking interest, just time and as I’m not too efficient* with Symphony’s API to pull this off right now…

*euphemism

@nitriques
Copy link
Member

Ok! I'll see what can be done. Thanks!

@nitriques
Copy link
Member

@tmslnz I am still open to work on this if you have time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants