Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add powder fitting tutorial #199

Merged
merged 11 commits into from
Aug 16, 2024
Merged

Add powder fitting tutorial #199

merged 11 commits into from
Aug 16, 2024

Conversation

RichardWaiteSTFC
Copy link
Collaborator

@RichardWaiteSTFC RichardWaiteSTFC commented Aug 1, 2024

Have got a .html file generated but don't know if there are other steps required to publish it.

To-Do

  • need to add test for bug fixed
  • Some typos

@RichardWaiteSTFC RichardWaiteSTFC marked this pull request as draft August 1, 2024 13:44
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 42.65%. Comparing base (1b52407) to head (636a358).
Report is 15 commits behind head on master.

Files Patch % Lines
swfiles/sw_fitpowder.m 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   42.37%   42.65%   +0.28%     
==========================================
  Files         240      241       +1     
  Lines       16184    16253      +69     
==========================================
+ Hits         6858     6933      +75     
+ Misses       9326     9320       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 1, 2024

Test Results

    4 files  ± 0    116 suites  +4   4m 56s ⏱️ +20s
  733 tests +13    715 ✅ +13  18 💤 ±0  0 ❌ ±0 
2 104 runs  +52  2 068 ✅ +52  36 💤 ±0  0 ❌ ±0 

Results for commit 636a358. ± Comparison against base commit 1b52407.

♻️ This comment has been updated with latest results.

@RichardWaiteSTFC RichardWaiteSTFC marked this pull request as ready for review August 2, 2024 10:13
Copy link
Member

@mducle mducle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I made a mistake in the instrument resolution parameters - could you change it and run publish_PSI('tutorial39.m') again please?

tutorials/publish/tutorial39.m Show resolved Hide resolved
tutorials/publish/tutorial39.m Outdated Show resolved Hide resolved
Copy link
Member

@mducle mducle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks

@mducle mducle merged commit d859b68 into master Aug 16, 2024
11 checks passed
@mducle mducle deleted the powder_fitting_tutorial branch September 3, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants