Move to GSettings #250
Merged
Move to GSettings #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be unnecessary to do this for release packages?
|
Q_Q 抱歉拖了这么久，这周我一定看。 |
Closed
SilverRainZ
reviewed
Jun 10, 2020
| @@ -33,4 +33,5 @@ jobs: | |||
| - name: Install | |||
| run: | | |||
| sudo make install; | |||
| sudo glib-compile-schemas /usr/local/share/glib-2.0/schemas | |||
| # - msg-nickserv: Login with /msg NickServ identify | ||
| # - sasl-plain: Login with SASL PLAIN mechanism | ||
| # - sasl-ecdsa: Login with SASL ECDSA-NIST256P-CHALLENGE mechanism | ||
| # String; Path to login certificate file (For method "sasl-ecdsa") |
There was a problem hiding this comment.
这个应该是 login-certificate 的注释？
| @@ -20,8 +20,8 @@ DEFS = -D PACKAGE='"$(PACKAGE)"' \ | |||
| -D PACKAGE_COPYRIGHT_DATES='"$(PACKAGE_COPYRIGHT_DATES)"' | |||
| GTK3FLAGS = $(shell pkg-config --cflags gtk+-3.0) | |||
| GTK3LIBS = $(shell pkg-config --libs gtk+-3.0) | |||
| LIBCONFIGFLAGS = $(shell pkg-config --cflags libconfig) | |||
| LIBCONFIGLIBS = $(shell pkg-config --libs libconfig) | |||
| GIOFLAGS = $(shell pkg-config --cflags gio-2.0) | |||
There was a problem hiding this comment.
其实应该不需要特别制定 GIO 的 flags，应该已经包含在 GTK 里了？
|
感谢，这个 PR 帮大忙了。 我的想法是让 GSetting 替代 SrnServerConfig、SrnChatConfig 等等的结构体，之后还要在这个 PR 的基础上继续开发，所以先合并到 dev/2.0 分支，因为是比较大的 breaking change，因此 GSetting 的支持也不会在 1.0 中出现 。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm almost done moving to GSettings. Waiting for more tests.
Ref: #249