Sui(impl): Add chat list order configuration #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for replying so late, just fired by my employer recently :-P |
SilverRainZ
reviewed
Aug 10, 2024
Exagone313
force-pushed
the
sidebar-sort-alphabetically
branch
from
df2ad25
to
bf2aa75
Compare
Exagone313
changed the title
|
@SilverRainZ I updated it. |
SilverRainZ
reviewed
Aug 26, 2024
src/core/app_config.c
Outdated
| @@ -16,5 +16,9 @@ void srn_application_config_free(SrnApplicationConfig *cfg){ | |||
| } | |||
|
|
|||
| SrnRet srn_application_config_check(SrnApplicationConfig *cfg){ | |||
| if (g_strcmp0(cfg->ui->window.chat_list_order, CHAT_LIST_ORDER_RECENT) != 0 | |||
| && g_strcmp0(cfg->ui->window.chat_list_order, CHAT_LIST_ORDER_ALPHABET) != 0){ | |||
| return SRN_ERR; | |||
There was a problem hiding this comment.
You can return RET_ERR(xxx") to provide a more friendly error message.
There was a problem hiding this comment.
@SilverRainZ Should I update the PO files after adding an error message?
There was a problem hiding this comment.
It is fine, we can do this when we want to refresh our translation.
Exagone313
force-pushed
the
sidebar-sort-alphabetically
branch
from
bf2aa75
to
6b596d1
Compare
Exagone313
force-pushed
the
sidebar-sort-alphabetically
branch
from
6b596d1
to
46cf5c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a way to sort channels alphabetically in the sidebar
Notes for the review:
sidebar-sortconfiguration value, but no other settings appear to have such checks. The default value I have provided inbuiltin.cfgis de facto arbitrary.list_sort_func