Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethought Account Service Model with reimagined Account Setup and new Account Overview #7

Merged
merged 103 commits into from
Sep 14, 2023
Merged

Rethought Account Service Model with reimagined Account Setup and new Account Overview #7

merged 103 commits into from
Sep 14, 2023

Commits on Jun 29, 2023

  1. Try an other target

    @PSchmiedmayer @Supereg
    PSchmiedmayer authored and Supereg committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    cc065c7 View commit details
    Browse the repository at this point in the history

  2. Try Using the TEST flag

    @PSchmiedmayer @Supereg
    PSchmiedmayer authored and Supereg committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    70499f8 View commit details
    Browse the repository at this point in the history

  3. Update Flags

    @PSchmiedmayer @Supereg
    PSchmiedmayer authored and Supereg committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    52d2627 View commit details
    Browse the repository at this point in the history

  4. Initial mockup for the unified account setup/login view

    @Supereg
    Supereg committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    290368a View commit details
    Browse the repository at this point in the history

  5. Initial modelling of the updated AccountService representation

    @Supereg
    Supereg committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    52ff2da View commit details
    Browse the repository at this point in the history

  6. Introduce AccountServiceViewStyles

    @Supereg
    Supereg committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    3a3e55d View commit details
    Browse the repository at this point in the history

  7. First prototype of default implemented KeyPasswordBaseAccountService

    @Supereg
    Supereg committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    9bddccc View commit details
    Browse the repository at this point in the history

  8. Minor UI fixes

    @Supereg
    Supereg committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    a8ce2a0 View commit details
    Browse the repository at this point in the history

  9. Organize files and restructure naming

    @Supereg
    Supereg committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    d0efc30 View commit details
    Browse the repository at this point in the history

  10. Integration of new AccountService. Provide more default views for Key… 

    …PasswordBase AccountService
    @Supereg
    Supereg committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    1ffa0d5 View commit details
    Browse the repository at this point in the history

  11. Add forgotten files

    @Supereg
    Supereg committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    ca73a48 View commit details
    Browse the repository at this point in the history

  12. Iteration with initial default password reset view

    @Supereg
    Supereg committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    3a0ed10 View commit details
    Browse the repository at this point in the history

  13. Some UI components and integrate with upcomming SpeziViews

    @Supereg
    Supereg committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    902a987 View commit details
    Browse the repository at this point in the history

  14. Introduce some more abstractions, view modifiers, project organization

    @Supereg
    Supereg committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    d539392 View commit details
    Browse the repository at this point in the history

  15. Add all the new files

    @Supereg
    Supereg committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    ef71a14 View commit details
    Browse the repository at this point in the history

  16. Move to main branch

    @Supereg
    Supereg committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    7d148bc View commit details
    Browse the repository at this point in the history

  17. Provide a nearly feature complete prototype

    @Supereg
    Supereg committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    4e6a81e View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2023

  1. Initial draft of the AccountValue system; some localization, Account … 

    …Summary Views
    @Supereg
    Supereg committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    af9636a View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. Rework AccountValue model, implement basic configuration update TestApp

    @Supereg
    Supereg committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    4c84149 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Organize AccountValue infrastructure

    @Supereg
    Supereg committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    fdd6ee7 View commit details
    Browse the repository at this point in the history

  2. Localization, documentation and restructuring (again)

    @Supereg
    Supereg committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    4a51331 View commit details
    Browse the repository at this point in the history

  3. Rework how the active AccountService is stored

    @Supereg
    Supereg committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    8a190f8 View commit details
    Browse the repository at this point in the history

  4. Minor adjustments

    @Supereg
    Supereg committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    b910fd8 View commit details
    Browse the repository at this point in the history

  5. Fail safe

    @Supereg
    Supereg committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    d0e30a8 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Upgrade SpeziViews module

    @Supereg
    Supereg committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    447c2d2 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Fix crashing previews due to pervious refactorings

    @Supereg
    Supereg committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    844419e View commit details
    Browse the repository at this point in the history

  2. Minor refactoring in the ValidationRule subsystem

    @Supereg
    Supereg committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    9a3b3af View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Upgrade to new Component Communication functionality

    @Supereg
    Supereg committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    fd56ba9 View commit details
    Browse the repository at this point in the history

  2. Update AccountValue system to be based on the SharedRepository infras… 

    …tructure
    @Supereg
    Supereg committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    b378dc4 View commit details
    Browse the repository at this point in the history

  3. Make Requirements Builder use KeyPaths for simpler API

    @Supereg
    Supereg committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    15231f0 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2023

  1. Support completly customizeable data entry views (like signup) with A… 

    …ccountValue-specified data entry views
    @Supereg
    Supereg committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    704d5ea View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Instantiate the SharedRepository for AccountServiceConfiguration

    @Supereg
    Supereg committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    549d47f View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Add a lot of documentation; slight refactorings and preparations for … 

    …Account Details modifications
    @Supereg
    Supereg committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    264a068 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/simple-account-view

    @Supereg
    Supereg committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    949be2f View commit details
    Browse the repository at this point in the history

  3. REUSE

    @Supereg
    Supereg committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    a769417 View commit details
    Browse the repository at this point in the history

  4. Resolve todos, some minor fixes and documentation updates

    @Supereg
    Supereg committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    23dd6c0 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. A bunch more documentation and minor improvements

    @Supereg
    Supereg committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    817a2e3 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Add initial mockup for the AccountOverview view and rethought the Acc… 

    …ountValueConfiguration infrastructure to support 'supported' values that are not 'collected' at signup
    @Supereg
    Supereg committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    cbf277c View commit details
    Browse the repository at this point in the history

  2. DataDisplay infrastructure for a generic AccountOverview

    @Supereg
    Supereg committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    0648386 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Iterate on the AccountOverview. Add discard button confirmation, add … 

    …remove and signout buttons, add ability to add account values, support value removal, fix DatePicker not clickable.
    @Supereg
    Supereg committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    8893e5b View commit details
    Browse the repository at this point in the history

  2. Restructure everything into a ViewModel. Implement logout and removal… 

    … with user confirmuation through alerts. Several improvements.
    @Supereg
    Supereg committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    8ec8157 View commit details
    Browse the repository at this point in the history

  3. Start implementing the NameOverview and the SecurityOverview

    @Supereg
    Supereg committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    eba9af6 View commit details
    Browse the repository at this point in the history

  4. Introduce AccountValueVisitor and fix a bunch of UI update issues

    @Supereg
    Supereg committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    f0f5130 View commit details
    Browse the repository at this point in the history

  5. Fully working AccountOverview (exlcuding the Name and Security subviews)

    @Supereg
    Supereg committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    d8cb99e View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. AccountOverview is now feature complete

    @Supereg
    Supereg committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    5362586 View commit details
    Browse the repository at this point in the history

  2. Remove unused code and minor improvements

    @Supereg
    Supereg committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    edb0605 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. AccountService can now declare what type of account values they suppo… 

    …rt and what account values they require to be configured
    @Supereg
    Supereg committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    297fc05 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Add support to delegate storage of account values to an AccountStorag… 

    …eStandard for non-supporting Account Services
    @Supereg
    Supereg committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    00cbb41 View commit details
    Browse the repository at this point in the history

  2. Properly distinguish between AccountKeys and AccountValues

    @Supereg
    Supereg committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    57da7c2 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Add a lot of inline documentation and resolve some todos

    @Supereg
    Supereg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    9af5744 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/simple-account-view

    @Supereg
    Supereg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    e054ced View commit details
    Browse the repository at this point in the history

  3. German localization

    @Supereg
    Supereg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    3f3544b View commit details
    Browse the repository at this point in the history

  4. Remove the all containing DataEntryConfiguration

    @Supereg
    Supereg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    77b94e2 View commit details
    Browse the repository at this point in the history

  5. Split out a lot of functionality of the AccountSetup view

    @Supereg
    Supereg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    59c3931 View commit details
    Browse the repository at this point in the history

  6. Minor UI improvements

    @Supereg
    Supereg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    607fdf9 View commit details
    Browse the repository at this point in the history

  7. Fix some minor UI issues

    @Supereg
    Supereg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    542b2ae View commit details
    Browse the repository at this point in the history

  8. Resolve todos and provide inline docs

    @Supereg
    Supereg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    4381cfa View commit details
    Browse the repository at this point in the history

  9. Make identity providers actually work. More docs more resolved todos

    @Supereg
    Supereg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    2e5d790 View commit details
    Browse the repository at this point in the history

  10. Resolve all todos except of documentation links and todos in Test target

    @Supereg
    Supereg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    2d81f24 View commit details
    Browse the repository at this point in the history

  11. Updated DocC articles

    @Supereg
    Supereg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    b719448 View commit details
    Browse the repository at this point in the history

  12. Some more structure for the DocC articles

    @Supereg
    Supereg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    3bcef20 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Do all the structuring of the DocC articles and documentation pages

    @Supereg
    Supereg committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    4e4877c View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Optimize how initial values (previoulsy empty values) are handled and… 

    … optimize nonEmpty validation
    @Supereg
    Supereg committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    10279a9 View commit details
    Browse the repository at this point in the history

  2. Finish all documentation

    @Supereg
    Supereg committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    adc1079 View commit details
    Browse the repository at this point in the history

  3. Update docs link

    @Supereg
    Supereg committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    c91f67d View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Make not providing a Date in scenarios where Date Of Birth is optiona… 

    …l visually more explicit
    @Supereg
    Supereg committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    26a6930 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2023

  1. Rework the TestApp and push first working UI tests

    @Supereg
    Supereg committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    f3e969e View commit details
    Browse the repository at this point in the history

  2. First bunch of UI tests

    @Supereg
    Supereg committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    c82c9c4 View commit details
    Browse the repository at this point in the history

  3. Fix tests

    @Supereg
    Supereg committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    fb27c93 View commit details
    Browse the repository at this point in the history

  4. Fix test configuration

    @Supereg
    Supereg committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    bcc7858 View commit details
    Browse the repository at this point in the history

  5. Password reset tests

    @Supereg
    Supereg committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    8993913 View commit details
    Browse the repository at this point in the history

  6. Fix some timing

    @Supereg
    Supereg committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    74d54e7 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2023

  1. Complete signup UI tests

    @Supereg
    Supereg committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    edde606 View commit details
    Browse the repository at this point in the history

  2. Slight test adjustments

    @Supereg
    Supereg committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    4f770e7 View commit details
    Browse the repository at this point in the history

  3. More test vectors

    @Supereg
    Supereg committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    7ba23a9 View commit details
    Browse the repository at this point in the history

  4. Improve some timing

    @Supereg
    Supereg committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    5b1e954 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. First set of final UI tests. Fixed some bugs

    @Supereg
    Supereg committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    675577f View commit details
    Browse the repository at this point in the history

  2. Fix compiler warning about Sendable closure

    @Supereg
    Supereg committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    9290d37 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Spelling and Bool default conformance

    @Supereg
    Supereg committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    3a9e14d View commit details
    Browse the repository at this point in the history

  2. Spacing

    @Supereg
    Supereg committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    c3e4300 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2023

  1. Fix password entry. Some feedback adressed.

    @Supereg
    Supereg committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    d139fa6 View commit details
    Browse the repository at this point in the history

  2. Fix compilation

    @Supereg
    Supereg committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    7baa04a View commit details
    Browse the repository at this point in the history

  3. Remove custom submit labels

    @Supereg
    Supereg committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    ed71a53 View commit details
    Browse the repository at this point in the history

  4. Adjust swiftlint file

    @Supereg
    Supereg committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    5e3557b View commit details
    Browse the repository at this point in the history

  5. ValidationRule modifiers

    @Supereg
    Supereg committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    cb152d0 View commit details
    Browse the repository at this point in the history

  6. Feedback

    @Supereg
    Supereg committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    4b69b6e View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2023

  1. Disable buttons on invalid input. Restructure validation.

    @Supereg
    Supereg committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    cb714a6 View commit details
    Browse the repository at this point in the history

  2. Simplify ValidationEngine implementation

    @Supereg
    Supereg committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    0348ec8 View commit details
    Browse the repository at this point in the history

  3. Update tests

    @Supereg
    Supereg committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    be335c8 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feature/simple-account-view

    @Supereg
    Supereg committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    2d937d2 View commit details
    Browse the repository at this point in the history

  5. Hide some of the accessibility labels for images that convey no inter… 

    …active meaning
    @Supereg
    Supereg committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    c6c3542 View commit details
    Browse the repository at this point in the history

  6. Some accessibility improvements, test stability and added some more p… 

    …reviews
    @Supereg
    Supereg committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    4b4234c View commit details
    Browse the repository at this point in the history

  7. Fix swiftlint

    @Supereg
    Supereg committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    a3b6314 View commit details
    Browse the repository at this point in the history

  8. Improve test stability of date picker

    @Supereg
    Supereg committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    6fdb0b7 View commit details
    Browse the repository at this point in the history

  9. Resolve issues with UI tests due to accessibility labels

    @Supereg
    Supereg committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    d956faf View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Update labels of NameKey and PasswordChangeSheet

    @Supereg
    Supereg committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    9a90109 View commit details
    Browse the repository at this point in the history

  2. Fix layout issues for the PasswordChangeSheet

    @Supereg
    Supereg committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    a0e9650 View commit details
    Browse the repository at this point in the history

  3. Improve accessibility of Date Picker, fix tests

    @Supereg
    Supereg committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    35a59ed View commit details
    Browse the repository at this point in the history

  4. Extend the documentation on validation

    @Supereg
    Supereg committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    7b3dcc9 View commit details
    Browse the repository at this point in the history

  5. Update tests due to changes to the accessibility representation

    @Supereg
    Supereg committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    b370638 View commit details
    Browse the repository at this point in the history

  6. Resolve swiftlint

    @Supereg
    Supereg committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    c2974e5 View commit details
    Browse the repository at this point in the history

  7. Update to latest SpeziViews version

    @Supereg
    Supereg committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    7bcd472 View commit details
    Browse the repository at this point in the history

  8. Fix phrasing and optimize line breaks for VCS

    @Supereg
    Supereg committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    e13b1f2 View commit details
    Browse the repository at this point in the history