feat: consolidate /recentgames, /dropper, /partygames and /bridge (#684)

apps/api/src/player/player.controller.ts

@@ -20,10 +20,8 @@ import {
   DeletePlayerResponse,
   ErrorResponse,
   GetPlayerResponse,
-  GetRecentGamesResponse,
   GetStatusResponse,
   PlayerNotFoundException,
-  RecentGamesNotFoundException,
   StatusNotFoundException,
 } from "@statsify/api-client";
 
@@ -78,22 +76,6 @@ export class PlayerController {
     };
   }
 
-  @ApiOperation({ summary: "Get the Recent Games of a Player" })
-  @ApiOkResponse({ type: GetRecentGamesResponse })
-  @ApiBadRequestResponse({ type: ErrorResponse })
-  @ApiNotFoundResponse({ type: RecentGamesNotFoundException })
-  @ApiNotFoundResponse({ type: PlayerNotFoundException })
-  @Auth()
-  @Get("/recentgames")
-  public async getRecentGames(@Query() { player: tag }: PlayerDto) {
-    const recentGames = await this.playerService.getRecentGames(tag);
-
-    return {
-      success: !!recentGames,
-      recentGames,
-    };
-  }
-
   @ApiOperation({ summary: "Get the Status of a Player" })
   @ApiOkResponse({ type: GetStatusResponse })
   @ApiBadRequestResponse({ type: ErrorResponse })

apps/api/src/player/player.service.ts

@@ -9,8 +9,6 @@
 import { type APIData, type Circular, type Flatten, flatten } from "@statsify/util";
 import {
   CacheLevel,
-  PlayerNotFoundException,
-  RecentGamesNotFoundException,
   StatusNotFoundException,
 } from "@statsify/api-client";
 import { HypixelService } from "#hypixel";
@@ -115,39 +113,22 @@ export class PlayerService {
 
     if (!player) throw new NotFoundException("player");
 
-    const status = await this.hypixelService.getStatus(player.uuid);
+    const [status, games] = await Promise.all([
+      this.hypixelService.getStatus(player.uuid),
+      this.hypixelService.getRecentGames(player.uuid),
+    ]);
 
     if (!status) throw new StatusNotFoundException(player);
 
     status.displayName = player.displayName;
     status.prefixName = player.prefixName;
     status.uuid = player.uuid;
     status.actions = player.status;
+    status.recentGames = games;
 
     return status;
   }
 
-  public async getRecentGames(tag: string) {
-    const player = await this.get(tag, CacheLevel.CACHE_ONLY, {
-      uuid: true,
-      displayName: true,
-      prefixName: true,
-    });
-
-    if (!player) throw new PlayerNotFoundException();
-
-    const games = await this.hypixelService.getRecentGames(player.uuid);
-
-    if (!games || !games.length) throw new RecentGamesNotFoundException(player);
-
-    return {
-      uuid: player.uuid,
-      displayName: player.displayName,
-      prefixName: player.prefixName,
-      games,
-    };
-  }
-
   /**
    *
    * @param tag UUID or Username of the player

apps/discord-bot/src/commands/arcade/arcade.profile.tsx

@@ -76,7 +76,7 @@ export const ArcadeProfile = ({
       break;
 
     case "dropper":
-      table = <DropperTable stats={arcade[api]} t={t} time={time} />;
+      table = <DropperTable stats={arcade[api]} t={t} time={time} submode={mode.submode} />;
       break;
 
     case "enderSpleef":
@@ -112,7 +112,7 @@ export const ArcadeProfile = ({
       break;
 
     case "partyGames":
-      table = <PartyGamesTable stats={arcade[api]} t={t} />;
+      table = <PartyGamesTable stats={arcade[api]} t={t} submode={mode.submode} time={time} />;
       break;
 
     case "pixelPainters":
@@ -149,7 +149,7 @@ export const ArcadeProfile = ({
         sidebar={sidebar}
         title={`§l${FormattedGame.ARCADE} §f${
           api === "overall" ? t("stats.wins") : "Stats"
-        } §r(${mode.formatted})`}
+        } §r(${mode.formatted}${mode.submode ? ` ${mode.submode.formatted}` : ""})`}
         time={time}
       />
       {table}