Fix some Sonar code smells

src/main/java/io/github/stefanbratanov/jvm/openai/File.java

@@ -6,4 +6,4 @@ public record File(
     long createdAt,
     String filename,
     String purpose,
-    @Deprecated String status) {}
+    @Deprecated(forRemoval = true) String status) {}

src/main/java/io/github/stefanbratanov/jvm/openai/OpenAIClient.java

@@ -149,7 +149,7 @@ private Optional<OpenAIException.Error> getErrorFromHttpResponse(HttpResponse<?>
       } else if (httpResponse.body() instanceof Path path) {
         body = Files.readAllBytes(path);
       } else if (httpResponse.body() instanceof Stream<?> stream) {
-        body = stream.map(elem -> (String) elem).collect(Collectors.joining()).getBytes();
+        body = stream.map(String.class::cast).collect(Collectors.joining()).getBytes();
       } else {
         return Optional.empty();
       }

src/test/java/io/github/stefanbratanov/jvm/openai/OpenAIAssistantsApiIntegrationTest.java

@@ -9,12 +9,12 @@
 import org.assertj.core.api.Assertions;
 import org.junit.jupiter.api.Test;
 
-public class OpenAIAssistantsApiIntegrationTest extends OpenAIIntegrationTestBase {
+class OpenAIAssistantsApiIntegrationTest extends OpenAIIntegrationTestBase {
 
   private static final Map<String, String> METADATA = Map.of("modified", "true", "user", "abc123");
 
   @Test
-  public void testThreadsClient() {
+  void testThreadsClient() {
     ThreadsClient threadsClient = openAI.threadsClient();
 
     CreateThreadRequest.Message message =
@@ -42,7 +42,7 @@ public void testThreadsClient() {
   }
 
   @Test
-  public void testMessagesClient() {
+  void testMessagesClient() {
     ThreadsClient threadsClient = openAI.threadsClient();
 
     MessagesClient messagesClient = openAI.messagesClient();
@@ -113,7 +113,7 @@ public void testMessagesClient() {
   }
 
   @Test
-  public void testAssistantsClient() {
+  void testAssistantsClient() {
     AssistantsClient assistantsClient = openAI.assistantsClient();
 
     File file = uploadRealEstateAgentAssistantFile();
@@ -179,7 +179,7 @@ public void testAssistantsClient() {
   }
 
   @Test
-  public void testRunsClient() {
+  void testRunsClient() {
     ThreadsClient threadsClient = openAI.threadsClient();
     AssistantsClient assistantsClient = openAI.assistantsClient();
 

src/test/java/io/github/stefanbratanov/jvm/openai/OpenAIIntegrationTest.java

@@ -16,10 +16,10 @@
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.io.TempDir;
 
-public class OpenAIIntegrationTest extends OpenAIIntegrationTestBase {
+class OpenAIIntegrationTest extends OpenAIIntegrationTestBase {
 
   @Test
-  public void testUnauthorizedRequest() {
+  void testUnauthorizedRequest() {
     OpenAI unauthorizedOpenAI = OpenAI.newBuilder("foobar").build();
 
     OpenAIException exception =
@@ -30,7 +30,7 @@ public void testUnauthorizedRequest() {
   }
 
   @Test
-  public void testChatClient() {
+  void testChatClient() {
     ChatClient chatClient = openAI.chatClient();
 
     CreateChatCompletionRequest request =
@@ -97,7 +97,7 @@ public void onComplete() {
   }
 
   @Test
-  public void testModelsClient() {
+  void testModelsClient() {
     ModelsClient modelsClient = openAI.modelsClient();
 
     List<Model> models = modelsClient.listModels();
@@ -110,7 +110,7 @@ public void testModelsClient() {
   }
 
   @Test
-  public void testAudioClient(@TempDir Path tempDir) {
+  void testAudioClient(@TempDir Path tempDir) {
     AudioClient audioClient = openAI.audioClient();
 
     SpeechRequest speechRequest =
@@ -147,7 +147,7 @@ public void testAudioClient(@TempDir Path tempDir) {
 
   @Test
   @Disabled("Image models are costly")
-  public void testImagesClient() {
+  void testImagesClient() {
     ImagesClient imagesClient = openAI.imagesClient();
 
     CreateImageRequest createImageRequest =
@@ -193,7 +193,7 @@ public void testImagesClient() {
   }
 
   @Test
-  public void testModerationsClient() {
+  void testModerationsClient() {
     ModerationsClient moderationsClient = openAI.moderationsClient();
 
     ModerationRequest request =
@@ -207,7 +207,7 @@ public void testModerationsClient() {
   }
 
   @Test
-  public void testEmbeddingsClient() {
+  void testEmbeddingsClient() {
     EmbeddingsClient embeddingsClient = openAI.embeddingsClient();
 
     EmbeddingsRequest request =
@@ -224,7 +224,7 @@ public void testEmbeddingsClient() {
   }
 
   @Test
-  public void testFilesClient() {
+  void testFilesClient() {
     FilesClient filesClient = openAI.filesClient();
 
     Path jsonlFile = getTestResource("/mydata.jsonl");
@@ -245,7 +245,7 @@ public void testFilesClient() {
 
   @Test
   @Disabled("Fine-tuning models are costly")
-  public void testFineTuningClient() {
+  void testFineTuningClient() {
     FilesClient filesClient = openAI.filesClient();
     FineTuningClient fineTuningClient = openAI.fineTuningClient();
 

src/test/java/io/github/stefanbratanov/jvm/openai/OpenApiSpecificationValidationTest.java

@@ -18,7 +18,7 @@
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.RepeatedTest;
 
-public class OpenApiSpecificationValidationTest {
+class OpenApiSpecificationValidationTest {
 
   private static final String OPEN_AI_SPECIFICATION_URL =
       "https://github.com/openai/openai-openapi/raw/master/openapi.yaml";
@@ -35,7 +35,7 @@ public static void setUp() {
   }
 
   @RepeatedTest(50)
-  public void validateAudio() {
+  void validateAudio() {
     SpeechRequest speechRequest = testDataUtil.randomSpeechRequest();
 
     Request request =
@@ -47,7 +47,7 @@ public void validateAudio() {
   }
 
   @RepeatedTest(50)
-  public void validateChat() {
+  void validateChat() {
     CreateChatCompletionRequest createChatCompletionRequest =
         testDataUtil.randomCreateChatCompletionRequest();
 
@@ -65,7 +65,7 @@ public void validateChat() {
   }
 
   @RepeatedTest(50)
-  public void validateEmbeddings() {
+  void validateEmbeddings() {
     EmbeddingsRequest embeddingsRequest = testDataUtil.randomEmbeddingsRequest();
 
     Embeddings embeddings = testDataUtil.randomEmbeddings();
@@ -80,7 +80,7 @@ public void validateEmbeddings() {
   }
 
   @RepeatedTest(50)
-  public void validateFineTuning() {
+  void validateFineTuning() {
     CreateFineTuningJobRequest createFineTuningJobRequest =
         testDataUtil.randomCreateFineTuningJobRequest();
 
@@ -117,7 +117,7 @@ public void validateFineTuning() {
   }
 
   @RepeatedTest(50)
-  public void validateFiles() {
+  void validateFiles() {
     File file = testDataUtil.randomFile();
 
     Response response = createResponseWithBody(serializeObject(file));
@@ -126,7 +126,7 @@ public void validateFiles() {
   }
 
   @RepeatedTest(50)
-  public void validateImages() {
+  void validateImages() {
     CreateImageRequest createImageRequest = testDataUtil.randomCreateImageRequest();
 
     Request request =
@@ -144,7 +144,7 @@ public void validateImages() {
   }
 
   @RepeatedTest(50)
-  public void validateModels() {
+  void validateModels() {
     Model model = testDataUtil.randomModelObject();
 
     Response response = createResponseWithBody(serializeObject(model));
@@ -153,7 +153,7 @@ public void validateModels() {
   }
 
   @RepeatedTest(50)
-  public void validateModerations() {
+  void validateModerations() {
     ModerationRequest moderationRequest = testDataUtil.randomModerationRequest();
 
     Request request =
@@ -168,7 +168,7 @@ public void validateModerations() {
   }
 
   @RepeatedTest(50)
-  public void validateAssistants() {
+  void validateAssistants() {
     CreateAssistantRequest createAssistantRequest = testDataUtil.randomCreateAssistantRequest();
 
     Request request =
@@ -185,7 +185,7 @@ public void validateAssistants() {
   }
 
   @RepeatedTest(50)
-  public void validateThreads() {
+  void validateThreads() {
     CreateThreadRequest createThreadRequest = testDataUtil.randomCreateThreadRequest();
 
     Request request =
@@ -210,7 +210,7 @@ public void validateThreads() {
   }
 
   @RepeatedTest(50)
-  public void validateMessages() {
+  void validateMessages() {
     CreateMessageRequest createMessageRequest = testDataUtil.randomCreateMessageRequest();
 
     Request request =
@@ -236,7 +236,7 @@ public void validateMessages() {
   }
 
   @RepeatedTest(50)
-  public void validateRuns() {
+  void validateRuns() {
     // Comment out until https://github.com/openai/openai-openapi/pull/170 is merged
     //    CreateRunRequest createRunRequest = testDataUtil.randomCreateRunRequest();
     //