Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When typing "exp" the app crashes #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

When typing "exp" the app crashes #21

wants to merge 1 commit into from

Conversation

ramiloif
Copy link

If you type exp the app will crash.
The reason is exp is a variable that exists in parse_expressions.js so when checking this expression it passes however it crashes in the "real" eval at viewer.js.
Same error happends if you type

  • code
  • transformedCode
  • codeByLine
  • tokenized
    ... and more

@ramiloif
Bind eval to an empty scope to avoid crashes
1ad6d6b 
When typing a variable that exists in current eval tha app will crash because
It will not exist in the "real" eval
@ramiloif ramiloif mentioned this pull request Jan 31, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ramiloif