Accounting for energy overlap in cross spectral products #865
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #865 +/- ##
=======================================
Coverage 96.06% 96.07%
=======================================
Files 48 48
Lines 9714 9723 +9
=======================================
+ Hits 9332 9341 +9
Misses 382 382 ☔ View full report in Codecov by Sentry. |
matteobachetti
requested review from
abigailStev,
matteolucchini1 and
eleonorav89
and removed request for
abigailStev
matteobachetti
changed the title
stingray/crossspectrum.py
Outdated
| def _calculate_errors(self): | ||
| """Calculate the errors on cross powers and lags. | ||
|
|
||
| Uses the formulas from Ingram 2019, MNRAS 489, 392. The attribute ``channels_overlap`` |
There was a problem hiding this comment.
Could it be better to indicate the formulas (the ones Matteo Lucchini wrote in the PR) or is it too specific? Also, I remember that in one of the first implementation of Ingram's approach in Stingray, a link to the paper was provided, although here you already put the reference. I leave you the choice to put the link or leave the reference as it is.
There was a problem hiding this comment.
The formulas are a little complicated, but I did expand the description and add a link to the paper in the original function and referred to that function here, hope it is more clear now
There was a problem hiding this comment.
Yes indeed it is clearer now, better this way. Thank you Matteo
Solving a bug, and taking it as a starting point to resolve #864