-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for recent ESPHome releases #9
base: master
Are you sure you want to change the base?
Conversation
- change switch restore_state to restore_mode as the former configuration option is not supported anymore - change `onboard_led` to be a status_led light platform, so it can be double purposed as both ESPHome Status LED and heating indicator - add some entity icons, device class
- API password is not supported anymore, it needs encryption
@@ -175,6 +179,7 @@ binary_sensor: | |||
pullup: True | |||
name: ${unit_name}_active | |||
id: power_active | |||
device_class: power |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that this device_class is right here. Its meant for current measuring in watts: https://developers.home-assistant.io/docs/core/entity/sensor/#:~:text=SensorDeviceClass.POWER
I suggest is to remove this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, see: https://www.home-assistant.io/integrations/binary_sensor/#device-class
Binary sensors have device class, which sets the icon and the name (language specific) for the state corresponding to true/false (like open/closed, locked/unlocked powered on/powered off).
In this case, device class power: on means power detected, off means no power, with appropriate state translated to each language, plus a plug icon with state coloring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thank you for contributing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Bump |
I don't have permissions to accept the PR. @Strooom merge please |
remove api/ota/etc as these are standard ESPHome config options to be seen in the doc. ota will soon change a bit, so no need to update this doc again, for something otherwise unrelated directly to this project
Ok, I'll take a look at it. |
restore_state
torestore_mode
as the former configuration option is not supported anymorestatus_led
light platform, so it can be double purposed as both ESPHome Status LED and heating indicator