Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for recent ESPHome releases #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nagyrobi
Copy link

@nagyrobi nagyrobi commented Nov 13, 2023

  • change switch restore_state to restore_mode as the former configuration option is not supported anymore
  • change onboard_led to be a status_led light platform, so it can be double purposed as both ESPHome Status LED and heating indicator
  • add some entity icons, device class
  • API password is not supported (deprecated) it needs encryption only

- change switch restore_state to restore_mode as the former configuration option is not supported anymore
- change `onboard_led` to be a status_led light platform, so it can be double purposed as both ESPHome Status LED and heating indicator
- add some entity icons, device class
- API password is not supported anymore, it needs encryption
@nagyrobi
Copy link
Author

@jensweimann

@@ -175,6 +179,7 @@ binary_sensor:
pullup: True
name: ${unit_name}_active
id: power_active
device_class: power
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this device_class is right here. Its meant for current measuring in watts: https://developers.home-assistant.io/docs/core/entity/sensor/#:~:text=SensorDeviceClass.POWER
I suggest is to remove this line

Copy link
Author

@nagyrobi nagyrobi Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, see: https://www.home-assistant.io/integrations/binary_sensor/#device-class

Binary sensors have device class, which sets the icon and the name (language specific) for the state corresponding to true/false (like open/closed, locked/unlocked powered on/powered off).

In this case, device class power: on means power detected, off means no power, with appropriate state translated to each language, plus a plug icon with state coloring.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thank you for contributing.

Copy link
Contributor

@jensweimann jensweimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@nagyrobi
Copy link
Author

Bump

@jensweimann
Copy link
Contributor

I don't have permissions to accept the PR. @Strooom merge please

remove api/ota/etc as these are standard ESPHome config options to be seen in the doc.
ota will soon change a bit, so no need to update this doc again, for something otherwise unrelated directly to this project
@Strooom
Copy link
Owner

Strooom commented May 29, 2024

Ok, I'll take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants