feat: show an error if the docker image identifier is invalid #3369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andre-code
temporarily deployed
to
renku-ci-ui-3369
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-ui-3369.dev.renku.ch |
Base automatically changed from
andrea/use-data-service-sessions-2.0
to
andrea/jupyter-free-build
October 18, 2024 14:03
andre-code
temporarily deployed
to
renku-ci-ui-3369
GitHub Actions
Inactive
andre-code
force-pushed
the
andrea/validate-image-when-launcing-session
branch
from
d4de56a
to
4fe7acc
Compare
andre-code
temporarily deployed
to
renku-ci-ui-3369
GitHub Actions
Inactive
andre-code
changed the title
andre-code
had a problem deploying
to
renku-ci-ui-3369
GitHub Actions
Failure
leafty
reviewed
Oct 23, 2024
| projectUrl: string; | ||
| }) { | ||
| if (!("status" in error)) { | ||
| return false; |
There was a problem hiding this comment.
You should not return false for a component.
Suggested change
| return false; | |
| return null; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to show an error if the docker image identifier is invalid.
Notion ref: https://www.notion.so/renku/Show-an-error-if-the-docker-image-identifier-is-invalid-1190df2efafc809682caee2d8c485285
/deploy renku=feat-jupyter-free-sessions renku-data-services=release-amaltheas-migration amalthea-sessions=main renku-notebooks=master renku-gateway=1.1.0 extra-values=amalthea-sessions.deployCrd=false