-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show an error if the docker image identifier is invalid #3369
base: andrea/jupyter-free-build
Are you sure you want to change the base?
feat: show an error if the docker image identifier is invalid #3369
Conversation
You can access the deployment of this PR at https://renku-ci-ui-3369.dev.renku.ch |
d4de56a
to
4fe7acc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. I would like to check the deployment before approving.
projectUrl: string; | ||
}) { | ||
if (!("status" in error)) { | ||
return false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not return false
for a component.
return false; | |
return null; |
PR to show an error if the docker image identifier is invalid.
Notion ref: https://www.notion.so/renku/Show-an-error-if-the-docker-image-identifier-is-invalid-1190df2efafc809682caee2d8c485285
/deploy renku=feat-jupyter-free-sessions renku-data-services=release-amaltheas-migration amalthea-sessions=main renku-notebooks=master renku-gateway=1.1.0 extra-values=amalthea-sessions.deployCrd=false