Skip to content

Commit

Permalink
fix: remove logic to avoid race condition in entrypoint
Browse files Browse the repository at this point in the history
Note: the race condition will be avoided by moving the cloning back to
an init container also with Amalthea.
  • Loading branch information
Andreas Bleuler authored and ableuler committed Sep 9, 2021
1 parent 6ac7fb8 commit 621e208
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions docker/py/entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,6 @@ then
fi

# install git hooks
# we need to avoid a race condition where renku could try to install
# the git hooks before the repo is actually cloned during the execution
# of the entrypoint of the git sidecar
if [[ -v GIT_CLONE_REPO && -v NOTEBOOK_DIR ]]
then
while [[ ! -f ./.renku-repo-clone-complete ]]
do
echo "Waiting for repository to be cloned..."
sleep 1
done
rm ./.renku-repo-clone-complete
fi
~/.local/bin/renku githooks install || true

# run the post-init script in the root directory (i.e. coming from the image)
Expand Down

0 comments on commit 621e208

Please sign in to comment.