Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding nebius api client #277

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fsndzomga
Copy link

What does this PR do?

This PR introduces the NebiusClient implementation for integrating with the Nebius API. It mirrors the functionality of the OpenAIClient but uses the Nebius API's base URL and corresponding environment variable (NEBIUS_API_KEY).

Summary:

  • Added NebiusClient class that inherits from ModelClient.
  • Updated the client to handle Nebius-specific configurations like base URL and API key.
  • Included support for both synchronous and asynchronous calls.
  • Added tests for the NebiusClient, similar to those for the OpenAIClient.

Motivation:

The Nebius API integration extends AdalFlow's capabilities to support Nebius-based models, enhancing the library's versatility.

Dependencies:

  • No new dependencies were introduced for this change.

Fixes #<issue_number> (if applicable)


Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
    ✅ Yes
  • Did you read the [contributor guideline](https://adalflow.sylph.ai/contributor/index.html)?
    ✅ Yes
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
    ✅ Yes
  • Did you make sure to update the documentation with your changes? (if necessary)
    ✅ Yes
  • Did you write any new necessary tests? (not for typos and docs)
    ✅ Yes
  • Did you verify new and existing tests pass locally with your changes?
    ✅ Yes
  • Did you list all the breaking changes introduced by this pull request?
    No breaking changes.

@liyin2015
Copy link
Member

@fsndzomga Thanks for adding the pr, but we should start an issue and some discussion with the community. We are not sure how this model client is wanted by users and what value it brings. Could you follow our contributor guide https://adalflow.sylph.ai/contributor/index.html

@fsndzomga
Copy link
Author

Hi @liyin2015 , thank you for the feedback! I’ll create an issue and follow the contributor guide for community discussion. Appreciate your guidance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants