Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve AWS bedrock integration #289

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

ajithvcoder
Copy link
Contributor

@ajithvcoder ajithvcoder commented Nov 30, 2024

What does this PR do?

  1. Fixed existing issues due to aws_profile_name and aws_region_name
  2. Fixed issues in list_models() and added support to pass arguments for specific model fetching
  3. Fixed convert_inputs_to_api_kwargs() to accept model as modelId and max_tokens as maxTokens internally
  4. Add functionality to accept inferenceConfig and additionalModelRequestFields
  5. Added aws_bedrock.rst file for documentation
  6. Added tutorials\bedrock_client_simple_qa.py for showing usage example
  7. Now bedrock can be used as similar to other models tutorials\generator_all_providers.py

Fixes #283

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)

  • Did you read the contributor guideline? yes

  • Did you make sure your PR does only one thing, instead of bundling different changes together?

  • Did you make sure to update the documentation with your changes? (if necessary) Yes

  • Did you write any new necessary tests? (not for typos and docs) Yes i have added mock tests and tutorials\bedrock_client_simple_qa.py

  • Did you verify new and existing tests pass locally with your changes? Yes

  • Did you list all the breaking changes introduced by this pull request? There is no breaking changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Bedrock integration improvement
1 participant