-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sprint 19 #370
Merged
Merged
Sprint 19 #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Issue 363] Weaver Components should use an alternate mechanism to display: none when components are ready.
…sprint19-staging
Some tests were not passing due to NULL problems. This temporarily adds NULL Coalesce checks to prevent test failures.
[Issue 333] The mobile service should use the ngrx store to maintain state.
[Issue 365] Build errors and other maintenance
When compiling nodejs from source, fs-extra is not automatically available.
[Issue 380] Refactor to pure pipes.
…out_store [Issue 382] Refactor mobile store to layout store.
Performance improvements - lazy loaded weaver elements
ghost
changed the title
Sprint19 staging
Sprint 19
May 27, 2021
ghost
marked this pull request as ready for review
May 27, 2021 17:11
ghost
previously approved these changes
May 27, 2021
Added path params to entry options
Added null safety and string interpolation to path vars
Sprint19 401 modal
ghost
previously approved these changes
Jun 1, 2021
jcreel
previously approved these changes
Jun 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice solution for concealing elements prior to completing DOM.
ghost
approved these changes
Aug 30, 2021
ghost
deleted the
sprint19-staging
branch
August 30, 2021 13:01
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mobile service should use the ngrx store to maintain state. (#333)
Weaver Components should use an alternate mechanism to display: none when components are ready (#363)
Weaver Components should use Ngrx to to maintain state. (#364)
Weaver Components should build without warnings (#365)
Refactor Template Service to Template Utility (#379)
Refactor to pure pipes (#380)
Remove isMobileAgent from base component (#381)
Refactor mobile store to layout store (#382)
Afford input text color on text component (#388)
Colors in color utility should be brought in via JSON (#390)
Weaver Components Manifest should support path variables (#398)