Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint 19 #370

Merged
61 commits merged into from
Aug 30, 2021
Merged

Sprint 19 #370

61 commits merged into from
Aug 30, 2021

Conversation

jeremythuff
Copy link
Member

@jeremythuff jeremythuff commented May 14, 2021

The mobile service should use the ngrx store to maintain state. (#333)
Weaver Components should use an alternate mechanism to display: none when components are ready (#363)
Weaver Components should use Ngrx to to maintain state. (#364)
Weaver Components should build without warnings (#365)
Refactor Template Service to Template Utility (#379)
Refactor to pure pipes (#380)
Remove isMobileAgent from base component (#381)
Refactor mobile store to layout store (#382)
Afford input text color on text component (#388)
Colors in color utility should be brought in via JSON (#390)
Weaver Components Manifest should support path variables (#398)

kaladay and others added 30 commits May 19, 2021 08:15
[Issue 363] Weaver Components should use an alternate mechanism to display: none when components are ready.
Some tests were not passing due to NULL problems.
This temporarily adds NULL Coalesce checks to prevent test failures.
[Issue 333] The mobile service should use the ngrx store to maintain state.
[Issue 365] Build errors and other maintenance
When compiling nodejs from source, fs-extra is not automatically available.
[Issue 380] Refactor to pure pipes.
…out_store

[Issue 382] Refactor mobile store to layout store.
Performance improvements - lazy loaded weaver elements
@ghost ghost changed the title Sprint19 staging Sprint 19 May 27, 2021
@ghost ghost marked this pull request as ready for review May 27, 2021 17:11
@ghost ghost requested review from rmathew1011, a user, kaladay and jcreel May 27, 2021 17:11
ghost
ghost previously approved these changes May 27, 2021
@ghost ghost dismissed their stale review via d32a051 May 28, 2021 21:13
ghost
ghost previously approved these changes Jun 1, 2021
jcreel
jcreel previously approved these changes Jun 1, 2021
Copy link
Member

@jcreel jcreel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution for concealing elements prior to completing DOM.

@rmathew1011 rmathew1011 dismissed stale reviews from jcreel and ghost via 2fe1986 June 4, 2021 15:23
@ghost ghost merged commit b5074c8 into master Aug 30, 2021
@ghost ghost deleted the sprint19-staging branch August 30, 2021 13:01
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants