Merge pull request #1939 from TEAMSchools/fix-magic-notes

fix: magic notes coming in on individual rows

.vscode/settings.json

@@ -44,10 +44,12 @@
   "[jsonc]": {
     "editor.defaultFormatter": "vscode.json-language-features"
   },
-  "dbt.perspectiveTheme": "Vintage",
   "dbt.deferConfigPerProject": {
     "src/dbt/kipptaf": {
-      "deferToProduction": false
+      "deferToProduction": true,
+      "favorState": false,
+      "manifestPathForDeferral": "/workspaces/teamster/src/dbt/kipptaf/target",
+      "manifestPathType": "local"
     }
   }
 }

src/dbt/kippcamden/package-lock.yml

@@ -0,0 +1,12 @@
+packages:
+  - local: ../deanslist
+  - local: ../edplan
+  - local: ../overgrad
+  - local: ../pearson
+  - local: ../powerschool
+  - local: ../titan
+  - package: dbt-labs/dbt_external_tables
+    version: 0.9.0
+  - package: dbt-labs/dbt_utils
+    version: 1.3.0
+sha1_hash: 7ef255b51530ffc832ae239c0228fbda1df5640a

src/dbt/kippmiami/package-lock.yml

@@ -0,0 +1,10 @@
+packages:
+  - local: ../deanslist
+  - local: ../iready
+  - local: ../powerschool
+  - local: ../renlearn
+  - package: dbt-labs/dbt_external_tables
+    version: 0.9.0
+  - package: dbt-labs/dbt_utils
+    version: 1.3.0
+sha1_hash: 4e897ba267484d3b780dab85292a264c56669935

src/dbt/kippnewark/package-lock.yml

@@ -0,0 +1,14 @@
+packages:
+  - local: ../deanslist
+  - local: ../edplan
+  - local: ../iready
+  - local: ../overgrad
+  - local: ../pearson
+  - local: ../powerschool
+  - local: ../renlearn
+  - local: ../titan
+  - package: dbt-labs/dbt_external_tables
+    version: 0.9.0
+  - package: dbt-labs/dbt_utils
+    version: 1.3.0
+sha1_hash: 6cce58ea5f384fc7dc41d808f3a3e18cf4b24231

src/dbt/kipptaf/models/schoolmint/grow/intermediate/int_schoolmint_grow__observations.sql

@@ -1,3 +1,10 @@
+with
+    magic_notes as (
+        select observation_id, string_agg(text, '; ') as magic_notes_text,
+        from {{ ref("stg_schoolmint_grow__observations__magic_notes") }}
+        group by observation_id
+    )
+
 select
     o.observation_id,
     o.rubric_id,
@@ -10,9 +17,7 @@ select
     o.observed_at_date_local,
     o.academic_year,
     o.is_published,
-
-    mn.text as magic_notes_text,
-
+    mn.magic_notes_text,
     s.name as school_name,
 
     gt.name as observation_type_name,
@@ -24,10 +29,9 @@ select
     safe_cast(ut.internal_id as int) as teacher_internal_id,
 
     safe_cast(uo.internal_id as int) as observer_internal_id,
+
 from {{ ref("stg_schoolmint_grow__observations") }} as o
-left join
-    {{ ref("stg_schoolmint_grow__observations__magic_notes") }} as mn
-    on o.observation_id = mn.observation_id
+left join magic_notes as mn on o.observation_id = mn.observation_id
 left join {{ ref("stg_schoolmint_grow__users") }} as ut on o.teacher_id = ut.user_id
 left join {{ ref("stg_schoolmint_grow__users") }} as uo on o.observer_id = uo.user_id
 left join

src/dbt/kipptaf/package-lock.yml

@@ -0,0 +1,6 @@
+packages:
+  - package: dbt-labs/dbt_external_tables
+    version: 0.9.0
+  - package: dbt-labs/dbt_utils
+    version: 1.3.0
+sha1_hash: 86e37da85bb51f86f1ab00f54df3d63a162424dc