[feat] 소셜 로그인 API 구현 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunwoongH
requested changes
Jan 7, 2024
|
|
||
| @RequiredArgsConstructor | ||
| @RequestMapping("/api/users") | ||
| @RestController |
There was a problem hiding this comment.
ResponseEntity를 응답으로 반환하는 경우 ResponseBody 어노테이션이 불필요하기 때문에 Controller 어노테이션을 적용해도 좋을 것 같습니다.
Comment on lines
+33
to
+41
| public UserResponse signIn(String token, UserSignInRequest request) { | ||
| Platform enumPlatform = getEnumPlatformFromStringPlatform(request.platform()); | ||
| String platformId = getPlatformId(token, enumPlatform); | ||
| User findUser = getUser(enumPlatform, platformId); | ||
| Token issueToken = jwtProvider.issueToken(findUser.getId()); | ||
| updateRefreshToken(issueToken.refreshToken(), findUser); | ||
|
|
||
| return UserResponse.of(issueToken); | ||
| } |
There was a problem hiding this comment.
클래스 레벨에 Transactional 어노테이션이 read only 옵션으로 적용되어 있어서 해당 클래스의 모든 public 메서드에서 변경 감지 동작이 이루어지지 않게 됩니다. 따라서 User 엔티티의 refresh token을 update 하는 과정이 정상 수행되지 않을 것 같습니다. 엔티티 데이터의 변경이 필요한 메서드 위에 read only 옵션이 적용되지 않은 Transactional 어노테이션을 추가적으로 적용하여 해결하면 좋을 것 같습니다.
SunwoongH
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue 📌
close #14
Description ✔️