[REFACTOR]/#85 - Converter와 ResponseDTO들 리팩토링 #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 개요
회원가입, 로그인 관련 로직에 참조되는 Converter 클래스들을 static으로 선언
회원가입, 로그인 관련 로직에서 오고가는 DTO들의 구조를 API 명세서에 맞게 수정
🔍 변경사항
⏳ 작업 내용
📝 논의사항
내가 받은 초대장 조회 API (
InvitationService)의getInvitations메서드에 초대장이 발신된 트리하우스 속 멤버들의 프로필 이미지를 포함시키는 로직이 있는데 개선의 여지가 있어보인다면 어떻게 고치는 게 좋을 지 궁금합니다!