-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge dev to refactor #11809
Open
Isira-Seneviratne
wants to merge
104
commits into
TeamNewPipe:refactor
Choose a base branch
from
Isira-Seneviratne:Merge-dev
base: refactor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Merge dev to refactor #11809
Isira-Seneviratne
wants to merge
104
commits into
TeamNewPipe:refactor
from
Isira-Seneviratne:Merge-dev
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8267d32.
…playlist" dialog list. Now both lists are sorted using case insensitive order if the user has not yet adjusted manually the order.
Fixed crashes from recycled bitmaps by creating real copies of bitmaps if necessary + some minor refactoring
…ue-on-video-change Fix Crash on Related Items Modal
This reverts commit 53edd05.
The tag can't be resolved by Jitpack so use the commit-hash instead
Co-Authored-By: Thompson3142 <115718208+thompson3142@users.noreply.github.com>
* IcePick fails on Java 21 (default in Android Studio 2024.2) * Bridge is the most modern alternative that is currently available. It is backed by ``Android-State`` and can be configured with various frameworks * In the long term this should be replaced with something better
Fix compilation
…-types-support Add support for secondary audio track type
Currently translated at 100.0% (81 of 81 strings) Translated using Weblate (Polish) Currently translated at 100.0% (739 of 739 strings) Translated using Weblate (Polish) Currently translated at 100.0% (739 of 739 strings) Translated using Weblate (Hungarian) Currently translated at 28.3% (23 of 81 strings) Translated using Weblate (Icelandic) Currently translated at 99.4% (735 of 739 strings) Translated using Weblate (Punjabi) Currently translated at 100.0% (739 of 739 strings) Translated using Weblate (Hindi) Currently translated at 100.0% (739 of 739 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (739 of 739 strings) Translated using Weblate (Slovak) Currently translated at 100.0% (81 of 81 strings) Translated using Weblate (Hungarian) Currently translated at 23.4% (19 of 81 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (81 of 81 strings) Translated using Weblate (Hungarian) Currently translated at 23.4% (19 of 81 strings) Translated using Weblate (Punjabi (Pakistan)) Currently translated at 16.9% (125 of 739 strings) Translated using Weblate (Chinese (Traditional Han script)) Currently translated at 66.6% (54 of 81 strings) Translated using Weblate (Albanian) Currently translated at 1.2% (1 of 81 strings) Translated using Weblate (Arabic) Currently translated at 100.0% (81 of 81 strings) Translated using Weblate (Polish) Currently translated at 60.4% (49 of 81 strings) Translated using Weblate (Hindi) Currently translated at 100.0% (81 of 81 strings) Translated using Weblate (Hungarian) Currently translated at 19.7% (16 of 81 strings) Translated using Weblate (Punjabi) Currently translated at 100.0% (81 of 81 strings) Translated using Weblate (Czech) Currently translated at 100.0% (81 of 81 strings) Translated using Weblate (Ukrainian) Currently translated at 100.0% (81 of 81 strings) Translated using Weblate (German) Currently translated at 100.0% (81 of 81 strings) Translated using Weblate (Punjabi) Currently translated at 100.0% (739 of 739 strings) Translated using Weblate (Hindi) Currently translated at 100.0% (739 of 739 strings) Translated using Weblate (German) Currently translated at 100.0% (739 of 739 strings) Co-authored-by: Agnieszka C <aga_04@o2.pl> Co-authored-by: D <dici.handy@gmail.com> Co-authored-by: Fjuro <fjuro@alius.cz> Co-authored-by: H Tamás <hovanszki@gmail.com> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: Jeff Huang <s8321414@gmail.com> Co-authored-by: MS-PC <MSPCtranslator@gmail.com> Co-authored-by: Milan <mobrcian@hotmail.com> Co-authored-by: Rex_sa <rex.sa@pm.me> Co-authored-by: ShareASmile <ShareASmile@users.noreply.hosted.weblate.org> Co-authored-by: Sveinn í Felli <sv1@fellsnet.is> Co-authored-by: Szymon Siemieniuk <szymonsiemieniuk01@gmail.com> Co-authored-by: VfBFan <VfBFan@users.noreply.hosted.weblate.org> Co-authored-by: Vladi69 <vladimirogalante@yahoo.it> Co-authored-by: gallegonovato <fran-carro@hotmail.es> Co-authored-by: Максим Горпиніч <mgorpinic2005@gmail.com> Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ar/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/cs/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/de/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/es/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/hi/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/hu/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/it/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pa/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pl/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/sk/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/sq/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/uk/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/zh_Hant/ Translation: NewPipe/Metadata
Release v0.27.3 (1000)
Fix downloading/exporting when overwriting file would not truncate
…popup_time Fix player resuming from start when clicking on a timestamp
Always allow changing player notification preferences on Android 13+
Add build-release-apk workflow
Currently translated at 9.8% (8 of 81 strings) Translated using Weblate (Malay) Currently translated at 57.9% (429 of 740 strings) Translated using Weblate (Portuguese (Portugal)) Currently translated at 96.2% (78 of 81 strings) Translated using Weblate (Portuguese (Brazil)) Currently translated at 64.1% (52 of 81 strings) Translated using Weblate (Hungarian) Currently translated at 50.6% (41 of 81 strings) Translated using Weblate (Icelandic) Currently translated at 99.4% (736 of 740 strings) Translated using Weblate (Arabic (Libya)) Currently translated at 4.9% (4 of 81 strings) Translated using Weblate (Indonesian) Currently translated at 100.0% (81 of 81 strings) Translated using Weblate (Hungarian) Currently translated at 32.0% (26 of 81 strings) Translated using Weblate (Portuguese) Currently translated at 100.0% (81 of 81 strings) Translated using Weblate (Turkish) Currently translated at 46.9% (38 of 81 strings) Translated using Weblate (Estonian) Currently translated at 100.0% (740 of 740 strings) Translated using Weblate (Azerbaijani) Currently translated at 100.0% (740 of 740 strings) Translated using Weblate (Bulgarian) Currently translated at 100.0% (740 of 740 strings) Translated using Weblate (Slovak) Currently translated at 100.0% (740 of 740 strings) Translated using Weblate (Greek) Currently translated at 100.0% (740 of 740 strings) Translated using Weblate (Basque) Currently translated at 100.0% (740 of 740 strings) Translated using Weblate (Portuguese) Currently translated at 100.0% (740 of 740 strings) Translated using Weblate (Hungarian) Currently translated at 100.0% (740 of 740 strings) Translated using Weblate (German) Currently translated at 100.0% (740 of 740 strings) Translated using Weblate (Japanese) Currently translated at 12.3% (10 of 81 strings) Translated using Weblate (Punjabi) Currently translated at 100.0% (740 of 740 strings) Translated using Weblate (Hindi) Currently translated at 100.0% (740 of 740 strings) Translated using Weblate (Chinese (Traditional Han script)) Currently translated at 100.0% (740 of 740 strings) Translated using Weblate (Chinese (Simplified Han script)) Currently translated at 100.0% (740 of 740 strings) Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (740 of 740 strings) Translated using Weblate (Polish) Currently translated at 100.0% (740 of 740 strings) Translated using Weblate (Ukrainian) Currently translated at 100.0% (740 of 740 strings) Translated using Weblate (Indonesian) Currently translated at 100.0% (740 of 740 strings) Translated using Weblate (Czech) Currently translated at 100.0% (740 of 740 strings) Translated using Weblate (Serbian) Currently translated at 100.0% (740 of 740 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (740 of 740 strings) Co-authored-by: Agnieszka C <aga_04@o2.pl> Co-authored-by: Aliberk Sandıkçı <git@aliberksandikci.com.tr> Co-authored-by: Dampuzakura <dampuzakura@users.noreply.hosted.weblate.org> Co-authored-by: Eder Etxebarria Rojo <eder@betxepare.eus> Co-authored-by: Femini <nizamismidov4@gmail.com> Co-authored-by: Fjuro <fjuro@alius.cz> Co-authored-by: Ghost of Sparta <makesocialfoss32@keemail.me> Co-authored-by: H Tamás <hovanszki@gmail.com> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: Igor Rückert <igorruckert@yahoo.com.br> Co-authored-by: Jeff Huang <s8321414@gmail.com> Co-authored-by: LeoL <leonardo.lapa.04@protonmail.com> Co-authored-by: Linerly <linerly@proton.me> Co-authored-by: Milan <mobrcian@hotmail.com> Co-authored-by: NEXI <nexiphotographer@gmail.com> Co-authored-by: Priit Jõerüüt <hwlate@joeruut.com> Co-authored-by: Retrial <giwrgosmant@gmail.com> Co-authored-by: Shafiq Jamzuri <shafiq.joe@yandex.com> Co-authored-by: ShareASmile <ShareASmile@users.noreply.hosted.weblate.org> Co-authored-by: Sveinn í Felli <sv1@fellsnet.is> Co-authored-by: VfBFan <VfBFan@users.noreply.hosted.weblate.org> Co-authored-by: gallegonovato <fran-carro@hotmail.es> Co-authored-by: trunars <trunars@gmail.com> Co-authored-by: Максим Горпиніч <mgorpinic2005@gmail.com> Co-authored-by: 大王叫我来巡山 <hamburger2048@users.noreply.hosted.weblate.org> Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ar_LY/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/hu/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/id/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ja/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ms/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pt/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pt_BR/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pt_PT/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/tr/ Translation: NewPipe/Metadata
Correct a Typo in Contributing.md
# Conflicts: # app/build.gradle # app/src/main/java/org/schabi/newpipe/App.java # app/src/main/java/org/schabi/newpipe/about/AboutActivity.kt # app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java # app/src/main/java/org/schabi/newpipe/fragments/list/channel/ChannelFragment.java # app/src/main/java/org/schabi/newpipe/fragments/list/comments/CommentRepliesFragment.java # app/src/main/java/org/schabi/newpipe/fragments/list/videos/RelatedItemsFragment.java # app/src/main/java/org/schabi/newpipe/local/bookmark/BookmarkFragment.java # app/src/main/res/values-bg/strings.xml # app/src/main/res/values-da/strings.xml # app/src/main/res/values-is/strings.xml # app/src/main/res/values-lv/strings.xml # app/src/main/res/values-zh-rTW/strings.xml # build.gradle
Quality Gate passedIssues Measures |
ShareASmile
added
meta
Related to the project but not strictly to code
rewrite
Issues and PRs related to rewrite
labels
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
meta
Related to the project but not strictly to code
rewrite
Issues and PRs related to rewrite
size/giant
PRs with more than 750 changed lines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
dev
branch torefactor
. This PR fixes several merge conflicts due to the changes indev
.APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence