Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Week to Start on Monday #1

Open
winsmith opened this issue Jun 27, 2024 · 2 comments
Open

Update Week to Start on Monday #1

winsmith opened this issue Jun 27, 2024 · 2 comments
Assignees

Comments

@winsmith
Copy link
Contributor

winsmith commented Jun 27, 2024

Update the Calendar object used in DateOperations to start a week on Monday instead of Sunday.

This updates relative time intervals in queries to use Monday instead of Sunday as well.

@Jeehut
Copy link

Jeehut commented Jul 1, 2024

Part of this, we had also discussed that the titles of the date picker options such as "This Week" and "Last Week" are somewhat unclear and can be misunderstood as "Last 7 Days". To clarify things, I suggested we add the sample dates such as "This Week (1st-6th)". I'll handle this aspect as part of this task as well.

@Jeehut
Copy link

Jeehut commented Jul 1, 2024

@winsmith I've given the implementation of this a try with the following PR, but not very confident about things, please take a look:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants