Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add start of week as new option in models #36

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add start of week as new option in models #36

wants to merge 2 commits into from

Conversation

Jeehut
Copy link

@Jeehut Jeehut commented Jul 1, 2024 •
edited
Loading

@Jeehut Jeehut requested a review from winsmith July 1, 2024 22:51
@Jeehut Jeehut mentioned this pull request Jul 1, 2024
Open
winsmith
winsmith approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@winsmith winsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, so feel free to merge, but I'm afraid I'll have to postpone the other PRs until I have a bit of breathing room

@Jeehut
Copy link
Author

Jeehut commented Jul 15, 2024 •
edited
Loading

@winsmith I don't feel comfortable merging this without you having had a proper look. I don't feel confident about this PR. I have a feeling there could be a better way to implement this whole thing, so I'll wait with the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winsmith winsmith winsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jeehut @winsmith