Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split GenomeAuthoritySystem based on modules #120

Merged
merged 3 commits into from
Aug 16, 2021

Commits on Aug 13, 2021

  1. feat: split GenomeAuthoritySystem based on modules

    The integration with Genome and BasicCrafting is optional for SimpleFarming.
    
    As a component system can only be loaded properly if all it's dependencies are also active, this means that the combined `GenomeAuthoritySystem` is only loaded if **both** Genome and BasicCrafting are active.
    
    By splitting the authority system into `GenomeExtensionAuthoritySystem` and `GenomeCraftingExtensionAuthoritySystem` each extension system can run with the minimal set of required modules.
    
    - `GenomeExtensionAuthoritySystem` (works if at least Genome is loaded)
    - `GenomeCraftingExtensionAuthoritySystem` (works if both Genome and Basic Crafting are loaded)
    
    Fixes #119
    skaldarnar committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    ccddcf7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    26fdde4 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2021

  1. feat: add 'requiresOptional' annotation metadata to genome extension …

    …systems
    
    I don't really know what the effect of that is, but it kind of makes sense to use the annotation field to document the optional dependencies in a way that we can more easily pick them up when registering systems.
    skaldarnar committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    4c58619 View commit details
    Browse the repository at this point in the history