chore: migrate flutter 3.19 #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lollipopkit
commented
Feb 18, 2024
lollipopkit
commented
- TextScaler
- KeyEvent
| ctrl: event.isControlPressed, | ||
| alt: event.isAltPressed, | ||
| shift: event.isShiftPressed, | ||
| ctrl: event.physicalKey == PhysicalKeyboardKey.controlLeft || |
There was a problem hiding this comment.
I think you'll find that the shift and control keys don't work as expected in your terminal editor. According to the RawKeyEvent docs the correct replacement for isShiftPressed is HardwareKeyboard.isShiftPressed.
See https://github.com/TerminalStudio/xterm.dart/pull/190/files#diff-d62cc3ae7257875f8ff5223bcb0ba25023d5e12166597467e693d3f10378b87eR423 for my implementation.
Hth!
There was a problem hiding this comment.
Sorry, I will modify it later. Thanks.
|
A better pr: #190 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.