Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

case-insenitive Bearer check #134 #135

Merged
merged 8 commits into from
Aug 28, 2024
Merged

case-insenitive Bearer check #134 #135

merged 8 commits into from
Aug 28, 2024

Conversation

JoshMcCullough
Copy link
Contributor

See #134.

@JoshMcCullough JoshMcCullough mentioned this pull request Aug 28, 2024
Closed
btahir0
btahir0 reviewed Aug 28, 2024
View reviewed changes
openssl.dockerfile
RUN rm -rf ${SRC_DIR}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to remove this or uncomment it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was unclear -- just removing the comment, keeping the RUN.

btahir0
btahir0 approved these changes Aug 28, 2024
View reviewed changes
Copy link

@btahir0 btahir0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, just a minor follow up about the commented line.

@JoshMcCullough JoshMcCullough merged commit 02f4e17 into master Aug 28, 2024
13 checks passed
@JoshMcCullough JoshMcCullough deleted the jsm/issue-134 branch August 28, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btahir0 btahir0 btahir0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshMcCullough @btahir0