Fix: When using inline HTML styles, directly apply rules to anchors #3580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When exporting captured output to HTML, using inline CSS styles,
linked text is formatted as:
<span style="..."><a href="...">text</a></span>
It seems that Web browsers will then render the linked text
with the default style for unvisited links (typically blue).
The CSS rules are, however, correctly applied if put
directly on the anchor element:
<a style="..." href="...">text</a>
Tested with Firefox 128.4 and Google Chrome 131.
dottspina
changed the title
dottspina
added a commit
to dottspina/dtsh
that referenced
this pull request
Dec 9, 2024
When appending a captured command output to an existing HTML file, we asked the rich library Console.export_html() API to generate inline CSS styles rather than: - CSS class definitions in a <style> element - which the <span>s making the actual output will later point to using class identifiers This was handy: we didn't have to deal with "merging" existing classes and new HTML elements, both 1-indexed and overlapping. Unfortunately, the HTML generated by the rich library will render linked texts (e.g. a compatible string linked to a YAML binding file) with the Web browser's default style for unvisited links (typically blue), instead of the expected style (e.g. the one consistently used for compatible strings). This can produce ugly/confusing outputs [1]. We submitted a patch to the upstream rich library project [2]. This commit relies on dtsh.rich.html to decouple DTSh command output redirection to HTML files from the inline styles generated by the rich library. We may keep this approach even if the initial issue is fixed upstream. [1] #9 [2] Textualize/rich#3580
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
When exporting captured output to HTML, using inline CSS styles, linked text is formatted as:
It seems that Web browsers will then render the linked text with the default style for unvisited links (typically blue).
The CSS rules are, however, correctly applied if put directly on the anchor element:
Tested with Firefox 128.4 and Google Chrome 131.
Thanks.
[Edit: I can squash the commits if preferred.]