Merge pull request #2568 from Pinata-Consulting/global-place-easier-t…

…o-read-code global place: easier to read .tcl code
The-OpenROAD-Project · Nov 17, 2024 · ccd5a71 · ccd5a71
2 parents d1165a8 + 42c797a
commit ccd5a71
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 16 deletions.
diff --git a/flow/scripts/global_place.tcl b/flow/scripts/global_place.tcl
@@ -25,9 +25,7 @@ proc do_placement {global_placement_args} {
     -pad_right $::env(CELL_PAD_IN_SITES_GLOBAL_PLACEMENT)] \
     $global_placement_args]
 
-  if { 0 != [llength [array get ::env GLOBAL_PLACEMENT_ARGS]] } {
-    lappend all_args {*}$::env(GLOBAL_PLACEMENT_ARGS)
-  }
+  lappend all_args {*}$::env(GLOBAL_PLACEMENT_ARGS)
 
   log_cmd global_placement {*}$all_args
 }

diff --git a/flow/scripts/global_place_skip_io.tcl b/flow/scripts/global_place_skip_io.tcl
@@ -2,22 +2,13 @@ source $::env(SCRIPTS_DIR)/load.tcl
 erase_non_stage_variables place
 load_design 2_floorplan.odb 2_floorplan.sdc
 
-
 if { [env_var_exists_and_non_empty FLOORPLAN_DEF] } {
   puts "FLOORPLAN_DEF is set. Skipping global placement without IOs"
 } else {
-  set place_density [place_density_with_lb_addon]
-
-  if { 0 != [llength [array get ::env GLOBAL_PLACEMENT_ARGS]] } {
-    log_cmd global_placement -skip_io -density $place_density \
-        -pad_left $::env(CELL_PAD_IN_SITES_GLOBAL_PLACEMENT) \
-        -pad_right $::env(CELL_PAD_IN_SITES_GLOBAL_PLACEMENT) \
-        {*}$::env(GLOBAL_PLACEMENT_ARGS)
-  } else {
-    log_cmd global_placement -skip_io -density $place_density \
-        -pad_left $::env(CELL_PAD_IN_SITES_GLOBAL_PLACEMENT) \
-        -pad_right $::env(CELL_PAD_IN_SITES_GLOBAL_PLACEMENT)
-  }
+  log_cmd global_placement -skip_io -density [place_density_with_lb_addon] \
+      -pad_left $::env(CELL_PAD_IN_SITES_GLOBAL_PLACEMENT) \
+      -pad_right $::env(CELL_PAD_IN_SITES_GLOBAL_PLACEMENT) \
+      {*}$::env(GLOBAL_PLACEMENT_ARGS)
 }
 
 write_db $::env(RESULTS_DIR)/3_1_place_gp_skip_io.odb
diff --git a/flow/scripts/variables.yaml b/flow/scripts/variables.yaml
@@ -318,6 +318,7 @@ REPAIR_PDN_VIA_LAYER:
 GLOBAL_PLACEMENT_ARGS:
   description: >
     Use additional tuning parameters during global placement other than default args defined in global_place.tcl.
+  default: ""
 ENABLE_DPO:
   description: >
     Enable detail placement with improve_placement feature.