Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Codebase for Xcode 16.0 and Swift 6 Compatibility & Optimisation #106

Open
IAmVigneswaran opened this issue Sep 20, 2024 · 5 comments
Open

Update Codebase for Xcode 16.0 and Swift 6 Compatibility & Optimisation #106

IAmVigneswaran opened this issue Sep 20, 2024 · 5 comments
Assignees
@milanvarady
Labels
bug Something Isn't Working enhancement New Feature Or Request markers-extractor api MarkersExtractor (CLI & LibraryI) Related
Milestone
1.1.0

Comments

@IAmVigneswaran
Copy link
Contributor

@milanvarady Thank you for making the tweaks for Xcode 16.0. While the build is successful, there are several warnings shown during the build process.

Are we able to fix and solve them?

 Processing Info.plist
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Utilities/Extensions/RoleExtension.swift:11:1: extension declares a conformance of imported type 'AnyRole' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'DAWFileKit' introduce this conformance in the future
extension FinalCutPro.FCPXML.AnyRole: Identifiable, Codable {
^
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Color Swatch/ColorsExtractorService/DeltaEFormulaExtension.swift:29:1: extension declares a conformance of imported type 'DeltaEFormula' to imported protocol 'CustomStringConvertible'; this will not behave correctly if the owners of 'DominantColors' introduce this conformance in the future
extension DeltaEFormula: CustomStringConvertible {
^                                     ~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Settings/MarkersExtractorModelExtensions.swift:11:1: extension declares a conformance of imported type 'ExportFolderFormat' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'MarkersExtractor' introduce this conformance in the future
extension ExportFolderFormat: Codable, Identifiable {
^                        ~~~~~~~~~~~~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Settings/MarkersExtractorModelExtensions.swift:28:1: extension declares a conformance of imported type 'MarkerIDMode' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'MarkersExtractor' introduce this conformance in the future
extension MarkerIDMode: Codable, Identifiable {
^                                      ~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Settings/MarkersExtractorModelExtensions.swift:45:1: extension declares a conformance of imported type 'AlignHorizontal' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'MarkersExtractor' introduce this conformance in the future
extension MarkerLabelProperties.AlignHorizontal: Codable, Identifiable {
^                                ~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Settings/MarkersExtractorModelExtensions.swift:62:1: extension declares a conformance of imported type 'AlignVertical' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'MarkersExtractor' introduce this conformance in the future
extension MarkerLabelProperties.AlignVertical: Codable, Identifiable {
^                                                         ~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Settings/MarkersExtractorModelExtensions.swift:79:1: extension declares a conformance of imported type 'ExportField' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'MarkersExtractor' introduce this conformance in the future
extension ExportField: Codable, Identifiable {
^                                                       ~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Workflow Extension/WorkflowExtensionView.swift:82:26: call to main actor-isolated instance method 'handleDrop(data:)' in a synchronous nonisolated context; this is an error in the Swift 6 language mode
                    self.handleDrop(data: data)
^                               ~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Roles/RolesManager+DropDelegate.swift:49:34: main actor-isolated property 'loadingInProgress' can not be mutated from a nonisolated context; this is an error in the Swift 6 language mode
                            self.loadingInProgress = false
                 ^
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Roles/RolesManager+DropDelegate.swift:62:29: expression is 'async' but is not marked with 'await'; this is an error in the Swift 6 language mode
                            self.setRoles(extractedRoles)
                   ^
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Utilities/Extensions/RoleExtension.swift:11:1: extension declares a conformance of imported type 'AnyRole' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'DAWFileKit' introduce this conformance in the future
extension FinalCutPro.FCPXML.AnyRole: Identifiable, Codable {
                            ^
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Color Swatch/ColorsExtractorService/DeltaEFormulaExtension.swift:29:1: extension declares a conformance of imported type 'DeltaEFormula' to imported protocol 'CustomStringConvertible'; this will not behave correctly if the owners of 'DominantColors' introduce this conformance in the future
extension DeltaEFormula: CustomStringConvertible {
^                                     ~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Settings/MarkersExtractorModelExtensions.swift:11:1: extension declares a conformance of imported type 'ExportFolderFormat' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'MarkersExtractor' introduce this conformance in the future
extension ExportFolderFormat: Codable, Identifiable {
^                        ~~~~~~~~~~~~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Settings/MarkersExtractorModelExtensions.swift:28:1: extension declares a conformance of imported type 'MarkerIDMode' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'MarkersExtractor' introduce this conformance in the future
extension MarkerIDMode: Codable, Identifiable {
^                                      ~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Settings/MarkersExtractorModelExtensions.swift:45:1: extension declares a conformance of imported type 'AlignHorizontal' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'MarkersExtractor' introduce this conformance in the future
extension MarkerLabelProperties.AlignHorizontal: Codable, Identifiable {
^                                ~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Settings/MarkersExtractorModelExtensions.swift:62:1: extension declares a conformance of imported type 'AlignVertical' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'MarkersExtractor' introduce this conformance in the future
extension MarkerLabelProperties.AlignVertical: Codable, Identifiable {
^                                                         ~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Settings/MarkersExtractorModelExtensions.swift:79:1: extension declares a conformance of imported type 'ExportField' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'MarkersExtractor' introduce this conformance in the future
extension ExportField: Codable, Identifiable {
^                                                       ~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Workflow Extension/WorkflowExtensionView.swift:82:26: call to main actor-isolated instance method 'handleDrop(data:)' in a synchronous nonisolated context; this is an error in the Swift 6 language mode
                    self.handleDrop(data: data)
^                               ~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Roles/RolesManager+DropDelegate.swift:49:34: main actor-isolated property 'loadingInProgress' can not be mutated from a nonisolated context; this is an error in the Swift 6 language mode
                            self.loadingInProgress = false
                 ^
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Roles/RolesManager+DropDelegate.swift:62:29: expression is 'async' but is not marked with 'await'; this is an error in the Swift 6 language mode
                            self.setRoles(extractedRoles)
                   ^
▸ Linking Workflow\
▸ Linking Workflow\
▸ Generating 'Workflow\ Extension.appex.dSYM'
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Other/ExportDestinationPicker.swift:106:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
                            ^
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ExtractView.swift:356:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ExtractView.swift:357:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var databaseManager = DatabaseManager(settings: settings)
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ExtractView.swift:359:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var extractionModel = ExtractionModel(
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/Label/OverlaySettingsView.swift:143:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/General Settings/FileSettingsView.swift:116:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/General Settings/FileSettingsView.swift:117:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var databaseManager = DatabaseManager(settings: settings)
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/General Settings/NotificationSettingsView.swift:55:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/General Settings/NotificationSettingsView.swift:56:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var databaseManager = DatabaseManager(settings: settings)
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ContentView.swift:138:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ContentView.swift:139:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var databaseManager = DatabaseManager(settings: settings)
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ContentView.swift:141:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var extractionModel = ExtractionModel(
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ContentView.swift:146:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var queueModel = QueueModel(
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/QueueView.swift:184:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/QueueView.swift:185:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var databaseManager = DatabaseManager(settings: settings)
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/QueueView.swift:187:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var queueModel = QueueModel(
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/Image/SwatchSettingsView.swift:94:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Roles/RolesManager+DropDelegate.swift:49:34: main actor-isolated property 'loadingInProgress' can not be mutated from a nonisolated context; this is an error in the Swift 6 language mode
                            self.loadingInProgress = false
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Roles/RolesManager+DropDelegate.swift:62:29: expression is 'async' but is not marked with 'await'; this is an error in the Swift 6 language mode
                            self.setRoles(extractedRoles)
                   ^
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Settings/MarkersExtractorModelExtensions.swift:11:1: extension declares a conformance of imported type 'ExportFolderFormat' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'MarkersExtractor' introduce this conformance in the future
extension ExportFolderFormat: Codable, Identifiable {
                            ^
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Settings/MarkersExtractorModelExtensions.swift:28:1: extension declares a conformance of imported type 'MarkerIDMode' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'MarkersExtractor' introduce this conformance in the future
extension MarkerIDMode: Codable, Identifiable {
^                                      ~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Settings/MarkersExtractorModelExtensions.swift:45:1: extension declares a conformance of imported type 'AlignHorizontal' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'MarkersExtractor' introduce this conformance in the future
extension MarkerLabelProperties.AlignHorizontal: Codable, Identifiable {
^                                ~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Settings/MarkersExtractorModelExtensions.swift:62:1: extension declares a conformance of imported type 'AlignVertical' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'MarkersExtractor' introduce this conformance in the future
extension MarkerLabelProperties.AlignVertical: Codable, Identifiable {
^                                                         ~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Settings/MarkersExtractorModelExtensions.swift:79:1: extension declares a conformance of imported type 'ExportField' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'MarkersExtractor' introduce this conformance in the future
extension ExportField: Codable, Identifiable {
^                                                       ~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Color Swatch/ColorsExtractorService/DeltaEFormulaExtension.swift:29:1: extension declares a conformance of imported type 'DeltaEFormula' to imported protocol 'CustomStringConvertible'; this will not behave correctly if the owners of 'DominantColors' introduce this conformance in the future
extension DeltaEFormula: CustomStringConvertible {
^                               ~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Utilities/Extensions/RoleExtension.swift:11:1: extension declares a conformance of imported type 'AnyRole' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'DAWFileKit' introduce this conformance in the future
extension FinalCutPro.FCPXML.AnyRole: Identifiable, Codable {
^                        ~~~~~~~~~~~~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Workflow Extension/WorkflowExtensionView.swift:82:26: call to main actor-isolated instance method 'handleDrop(data:)' in a synchronous nonisolated context; this is an error in the Swift 6 language mode
                    self.handleDrop(data: data)
^                                     ~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Extract/Extraction Model/ExtractionModel_DropDelegate.swift:54:29: mutation of captured var 'filesToProcess' in concurrently-executing code; this is an error in the Swift 6 language mode
                            filesToProcess.append(fileURL)
                 ^
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Other/ExportDestinationPicker.swift:106:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
                            ^
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ExtractView.swift:356:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ExtractView.swift:357:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var databaseManager = DatabaseManager(settings: settings)
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ExtractView.swift:359:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var extractionModel = ExtractionModel(
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/Label/OverlaySettingsView.swift:143:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/General Settings/FileSettingsView.swift:116:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/General Settings/FileSettingsView.swift:117:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var databaseManager = DatabaseManager(settings: settings)
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/General Settings/NotificationSettingsView.swift:55:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/General Settings/NotificationSettingsView.swift:56:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var databaseManager = DatabaseManager(settings: settings)
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ContentView.swift:138:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ContentView.swift:139:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var databaseManager = DatabaseManager(settings: settings)
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ContentView.swift:141:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var extractionModel = ExtractionModel(
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ContentView.swift:146:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var queueModel = QueueModel(
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/QueueView.swift:184:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/QueueView.swift:185:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var databaseManager = DatabaseManager(settings: settings)
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/QueueView.swift:187:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var queueModel = QueueModel(
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/Image/SwatchSettingsView.swift:94:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Roles/RolesManager+DropDelegate.swift:49:34: main actor-isolated property 'loadingInProgress' can not be mutated from a nonisolated context; this is an error in the Swift 6 language mode
                            self.loadingInProgress = false
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Roles/RolesManager+DropDelegate.swift:62:29: expression is 'async' but is not marked with 'await'; this is an error in the Swift 6 language mode
                            self.setRoles(extractedRoles)
                   ^
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Settings/MarkersExtractorModelExtensions.swift:11:1: extension declares a conformance of imported type 'ExportFolderFormat' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'MarkersExtractor' introduce this conformance in the future
extension ExportFolderFormat: Codable, Identifiable {
                            ^
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Settings/MarkersExtractorModelExtensions.swift:28:1: extension declares a conformance of imported type 'MarkerIDMode' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'MarkersExtractor' introduce this conformance in the future
extension MarkerIDMode: Codable, Identifiable {
^                                      ~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Settings/MarkersExtractorModelExtensions.swift:45:1: extension declares a conformance of imported type 'AlignHorizontal' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'MarkersExtractor' introduce this conformance in the future
extension MarkerLabelProperties.AlignHorizontal: Codable, Identifiable {
^                                ~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Settings/MarkersExtractorModelExtensions.swift:62:1: extension declares a conformance of imported type 'AlignVertical' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'MarkersExtractor' introduce this conformance in the future
extension MarkerLabelProperties.AlignVertical: Codable, Identifiable {
^                                                         ~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Settings/MarkersExtractorModelExtensions.swift:79:1: extension declares a conformance of imported type 'ExportField' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'MarkersExtractor' introduce this conformance in the future
extension ExportField: Codable, Identifiable {
^                                                       ~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Color Swatch/ColorsExtractorService/DeltaEFormulaExtension.swift:29:1: extension declares a conformance of imported type 'DeltaEFormula' to imported protocol 'CustomStringConvertible'; this will not behave correctly if the owners of 'DominantColors' introduce this conformance in the future
extension DeltaEFormula: CustomStringConvertible {
^                               ~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Utilities/Extensions/RoleExtension.swift:11:1: extension declares a conformance of imported type 'AnyRole' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'DAWFileKit' introduce this conformance in the future
extension FinalCutPro.FCPXML.AnyRole: Identifiable, Codable {
^                        ~~~~~~~~~~~~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Workflow Extension/WorkflowExtensionView.swift:82:26: call to main actor-isolated instance method 'handleDrop(data:)' in a synchronous nonisolated context; this is an error in the Swift 6 language mode
                    self.handleDrop(data: data)
^                                     ~~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Models/Extract/Extraction Model/ExtractionModel_DropDelegate.swift:54:29: mutation of captured var 'filesToProcess' in concurrently-executing code; this is an error in the Swift 6 language mode
                            filesToProcess.append(fileURL)

@orchetect The warning mentions MarkersExtractor and DAWFileKit? Should the libraries need to be updated for Xcode 16.0 compatibility?

Thank you.
@IAmVigneswaran IAmVigneswaran added the bug Something Isn't Working label Sep 20, 2024
@IAmVigneswaran IAmVigneswaran added this to the 1.0.1 milestone Sep 20, 2024
@orchetect
Copy link
Contributor

The new tooling only came out this week, I haven't had a chance to check MarkersExtractor. But most of these warnings are relating to the Marker Data codebase.

From the logs it looks like you're adding some conformances in Marker Data to types imported from MarkersExtractor. Things like Identifiable could be refactored into MarkersExtractor instead. Those particular warnings are only showing because it's unrecommended practice to conform types you don't own to protocols you don't own.

@IAmVigneswaran IAmVigneswaran mentioned this issue Sep 20, 2024
Closed
orchetect added a commit that referenced this issue Sep 21, 2024
@orchetect
Modifications for changes in MarkersExtractor 0.3.10 for Xcode 16/Swi…
bd077b2 
…ft 6 compatibility (#106)
@orchetect
Copy link
Contributor

orchetect commented Sep 21, 2024 •
edited
Loading

I've done the appropriate refactors and released MarkersExtractor 0.3.10.

I have also pushed a PR with changes for Marker Data in response to the refactors: #107

I only touched Marker Data code that was affected by MarkersExtractor. I will leave the remaining build warnings for @milanvarady to resolve, as they all now exclusively deal with the Marker Data codebase.

milanvarady added a commit that referenced this issue Sep 21, 2024
@milanvarady
Merge pull request #107 from TheAcharya/markersextractor-xcode-16-ref…
c03b2ae 
…actors

Updates for MarkersExtractor 0.3.10 for Xcode 16/Swift 6 compatibility (#106)
@IAmVigneswaran
Copy link
Contributor Author

@milanvarady

@latenitefilms Have shared some details for setting up Workflow Extensions in Xcode 16 https://fcp.cafe/#18th-september-2024

Thanks.

@IAmVigneswaran IAmVigneswaran added enhancement New Feature Or Request markers-extractor api MarkersExtractor (CLI & LibraryI) Related labels Sep 27, 2024
@IAmVigneswaran IAmVigneswaran changed the title Warnings during application build (Xcode 16.0) Update Codebase for Xcode 16.0 and Swift 6 Compatibility & Optimisation Sep 27, 2024
@IAmVigneswaran
Copy link
Contributor Author

IAmVigneswaran commented Sep 27, 2024 •
edited
Loading

@milanvarady I just tried to build the app again. The warnings are somewhat lesser than before.

⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Other/ExportDestinationPicker.swift:106:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ExtractView.swift:356:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ExtractView.swift:357:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var databaseManager = DatabaseManager(settings: settings)
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ExtractView.swift:359:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var extractionModel = ExtractionModel(
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/Label/OverlaySettingsView.swift:143:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/General Settings/FileSettingsView.swift:116:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/General Settings/FileSettingsView.swift:117:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var databaseManager = DatabaseManager(settings: settings)
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/General Settings/NotificationSettingsView.swift:55:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/General Settings/NotificationSettingsView.swift:56:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var databaseManager = DatabaseManager(settings: settings)
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ContentView.swift:139:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ContentView.swift:140:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var databaseManager = DatabaseManager(settings: settings)
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ContentView.swift:142:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var extractionModel = ExtractionModel(
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ContentView.swift:147:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var queueModel = QueueModel(
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/QueueView.swift:184:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/QueueView.swift:185:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var databaseManager = DatabaseManager(settings: settings)
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/QueueView.swift:187:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var queueModel = QueueModel(
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/Image/SwatchSettingsView.swift:94:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Other/ExportDestinationPicker.swift:106:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ExtractView.swift:356:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ExtractView.swift:357:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var databaseManager = DatabaseManager(settings: settings)
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ExtractView.swift:359:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var extractionModel = ExtractionModel(
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/Label/OverlaySettingsView.swift:143:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/General Settings/FileSettingsView.swift:116:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/General Settings/FileSettingsView.swift:117:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var databaseManager = DatabaseManager(settings: settings)
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/General Settings/NotificationSettingsView.swift:55:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/General Settings/NotificationSettingsView.swift:56:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var databaseManager = DatabaseManager(settings: settings)
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ContentView.swift:139:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ContentView.swift:140:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var databaseManager = DatabaseManager(settings: settings)
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ContentView.swift:142:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var extractionModel = ExtractionModel(
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Main/ContentView.swift:147:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var queueModel = QueueModel(
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/QueueView.swift:184:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/QueueView.swift:185:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var databaseManager = DatabaseManager(settings: settings)
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/QueueView.swift:187:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var queueModel = QueueModel(
    ^~~~~~~~~~~~
⚠️  /Users/runner/work/MarkerData/MarkerData/Source/Marker Data/Marker Data/Views/Detail Views/Image/SwatchSettingsView.swift:94:5: '@StateObject' used inline will not work unless tagged with '@Previewable'
    @StateObject var settings = SettingsContainer()
    ^~~~~~~~~~~~

@IAmVigneswaran
Copy link
Contributor Author

IAmVigneswaran commented Sep 27, 2024 •
edited
Loading

Based on this apple developer forum post, this is a known issue in Xcode 16.

I believe this '@StateObject' used inline will not work unless tagged with '@Previewable' it would be fixed in future versions of Xcode.

Related -
https://www.avanderlee.com/swiftui/previewable-macro-usage-in-previews/
https://stackoverflow.com/questions/60105438/swiftui-preview-provider-with-binding-variables/66175501#66175501
https://www.hackingwithswift.com/forums/swift/new-atpreviewable-and-previewer-issues-for-swiftdata/27357
https://www.reddit.com/r/SwiftUI/comments/18xdv0h/why_dont_we_need_stateobject_since_xcode_15/?rdt=55626

@IAmVigneswaran IAmVigneswaran modified the milestones: 1.0.1, 1.1.0 Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@milanvarady milanvarady

Labels
bug Something Isn't Working enhancement New Feature Or Request markers-extractor api MarkersExtractor (CLI & LibraryI) Related
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
3 participants
@orchetect @milanvarady @IAmVigneswaran