Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently enable INSTALL project in Visual Studio solution #1037

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

xezon
Copy link
Contributor

@xezon xezon commented Dec 3, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2023

Codecov Report

Attention: 941 lines in your changes are missing coverage. Please review.

Comparison is base (cebd1ae) 2.78% compared to head (6180c93) 2.72%.
Report is 1 commits behind head on develop.

Files Patch % Lines
src/game/client/maputil.cpp 0.00% 536 Missing ⚠️
src/game/client/gui/gadget/gadgetlistbox.cpp 0.00% 124 Missing ⚠️
src/game/logic/scriptengine/scriptaction.cpp 0.00% 112 Missing ⚠️
src/game/logic/map/sideslist.cpp 0.00% 85 Missing ⚠️
src/game/logic/scriptengine/scriptcondition.cpp 0.00% 48 Missing ⚠️
src/game/common/system/quotedprintable.cpp 0.00% 18 Missing ⚠️
src/game/common/skirmishbattlehonors.cpp 0.00% 7 Missing ⚠️
src/game/client/system/image.h 0.00% 6 Missing ⚠️
src/game/common/userpreferences.cpp 0.00% 4 Missing ⚠️
src/game/common/crc.h 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1037      +/-   ##
===========================================
- Coverage     2.78%    2.72%   -0.06%     
===========================================
  Files          916      918       +2     
  Lines       101693   102636     +943     
  Branches     17207    17399     +192     
===========================================
- Hits          2828     2797      -31     
- Misses       98459    99435     +976     
+ Partials       406      404       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xezon
Copy link
Contributor Author

xezon commented Jan 26, 2024

OmniBlade:

INSTALL shouldn't run automatically each time the build is redone as part of the default project configuration. It would be the same as a call to make also installing the application at the same time. You could instead create a CMakeUserPresets.json file and set things like that in it and always generate your solutions using your custom preset.

If you let me know what options you normally configure it for I can probably whip up the presets file for you. TheAssemblyArmada/Vanilla-Conquer#746 has some examples for vanilla conquer that haven't been merged yet due to lack of time and other maintainers to review but allow cleaning up some config in the CMake files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants