Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize MaxAndArgmax to all Commutative Operations and Datatypes and all Destination Tensor Sizes #334

Open
wants to merge 34 commits into
base: master
Choose a base branch
from

Commits on Aug 26, 2017

  1. Configuration menu
    Copy the full SHA
    c3ae76c View commit details
    Browse the repository at this point in the history
  2. Add strb_init() function.

    It allows initializing at runtime an strb. This can't always be done at
    compile-time, for instance if it is dynamically allocated.
    obilaniu committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    939a115 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a21bcb5 View commit details
    Browse the repository at this point in the history
  4. Feedback Applied.

    Spaces after a bunch of keywords, do certain string appends more
    efficiently, no appending includes.
    obilaniu committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    6ed2534 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a0654c2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    67e163e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b88ae57 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0949626 View commit details
    Browse the repository at this point in the history
  9. Added testcases for all reductions.

    All tests pass, but currently the codegen is locked to the large code
    model (the small code model has most of the groundwork laid down but has
    several extra complexities which haven't yet been implemented, like
    atomic reduction operators.
    obilaniu committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    8fe9083 View commit details
    Browse the repository at this point in the history
  10. Muzzle incorrect GCC maybe-uninitialized diagnostic.

    Clang and MSVC correctly recognize that all paths to the allegedly-
    uninitialized variables are, in fact, dominated by their initialization.
    obilaniu committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    32bd11d View commit details
    Browse the repository at this point in the history
  11. Current State

    obilaniu committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    19bd939 View commit details
    Browse the repository at this point in the history
  12. Current State

    obilaniu committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    1a2df8d View commit details
    Browse the repository at this point in the history
  13. Remove warp axis select.

    obilaniu committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    fffd323 View commit details
    Browse the repository at this point in the history
  14. Massive cleanup.

    obilaniu committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    1cfe552 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    2317ca1 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    c3977d8 View commit details
    Browse the repository at this point in the history
  17. More fixes.

    40% of tests still failing, and the code has a wierd smell to it that I
    really don't appreciate.
    obilaniu committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    8fc792b View commit details
    Browse the repository at this point in the history
  18. Really dumb division bug fixed.

    All tests now pass except summation, which fails to meet tolerance.
    obilaniu committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    8debf2d View commit details
    Browse the repository at this point in the history
  19. Fix summation tests:

    - Subtract 0.5 from random numbers, so they sum to 0 in expectation.
    - Increase tolerance from 1e-5 to 1e-4 just for summation.
    obilaniu committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    5f4ec4e View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    eb108be View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    ce9c067 View commit details
    Browse the repository at this point in the history
  22. More refactoring.

    Now, all the veryhighrank tests pass and the others fail for an unknown
    reason.
    obilaniu committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    c9a0389 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    6fb0793 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    4a17f48 View commit details
    Browse the repository at this point in the history
  25. Add a bunch of local_barrier()'s.

    They are overkill but seem to fix the problems with the testcases, at
    least so far.
    obilaniu committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    328c957 View commit details
    Browse the repository at this point in the history
  26. Style fixes.

    obilaniu committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    925688c View commit details
    Browse the repository at this point in the history
  27. Muzzle -Wdeclaration-after-statement in check_reduction.c.

    There is now not a single -Wdeclaration-after-statement warning
    origination in that file.
    obilaniu committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    8f5250e View commit details
    Browse the repository at this point in the history
  28. Easy feedback fixes applied.

    obilaniu committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    fac52b6 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    f129c69 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    76fd38c View commit details
    Browse the repository at this point in the history
  31. Added missing header

    obilaniu committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    0832fa1 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2017

  1. Configuration menu
    Copy the full SHA
    c679474 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ecde75c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    79d3649 View commit details
    Browse the repository at this point in the history