Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no subscribers fallback option to GoChannel Pub/Sub #418

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add no subscribers fallback option to GoChannel Pub/Sub #418

wants to merge 6 commits into from

Commits on Apr 10, 2024

  1. Fix grammar in comment

    @annismckenzie
    annismckenzie committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    9088eb3 View commit details
    Browse the repository at this point in the history

  2. Add EnableFallback configuration option and const for topic

    @annismckenzie
    annismckenzie committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    f6e8580 View commit details
    Browse the repository at this point in the history

  3. Implement EnableFallback configuration option 

    If the option is enabled, messages sent to topic without any subscribers
will be forwarded to the `*` topic subscribers.
    @annismckenzie
    annismckenzie committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    68cd6df View commit details
    Browse the repository at this point in the history

  4. Improve implementation of the EnableFallback configuration option 

    This goes back to the simple if and an early return when the option isn't enabled.
    @annismckenzie
    annismckenzie committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    0eae6f7 View commit details
    Browse the repository at this point in the history

  5. Move fallback topic option to the configuration and allow the topic t… 

    …o be configured
    @annismckenzie
    annismckenzie committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    c2ff17b View commit details
    Browse the repository at this point in the history

  6. Improve clarity of comments on exported methods

    @annismckenzie
    annismckenzie committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    8808fd7 View commit details
    Browse the repository at this point in the history