add windows nvme support #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add windows nvme support
make some change in code
|
Looks great! I'll have a chance to test properly this weekend. |
|
Haven't yet been able to steal a box with a real copy of Windows. The NVMe emulation in VirtualBox seems to be too barebones to test properly. |
|
@TkTech If you would make some test cases, I |
|
I've managed to get basic NVMe device emulation working under VirtualBox using the workaround found in https://www.virtualbox.org/ticket/17228. Started testing this last night but found a few bugs, will update the MR. |
check data length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add windows nvme support.
It works well windows 11, at least in my laptop.