Skip to content

Commit

Permalink
Increase max group message length by four bytes
Browse files Browse the repository at this point in the history
The max message length was reduced by 4 bytes to account for the pseudo message ID, which had unintended effects on clients. It makes more sense to increase the raw packet length by four and keep the max group message length the same as the max message length for friend chats.
  • Loading branch information
JFreegman committed Mar 3, 2023
1 parent b2ca401 commit 172f279
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ environment:

install:
- set PATH=C:\Python311-x64\Scripts;%PATH%
- py -3 -m pip install conan
- py -3 -m pip install conan==1.59.0
- git submodule update --init --recursive

for:
Expand Down
2 changes: 1 addition & 1 deletion other/bootstrap_daemon/docker/tox-bootstrapd.sha256
Original file line number Diff line number Diff line change
@@ -1 +1 @@
b0fafb30bffe21889f06a95edd3867f29a2203d30c2d7e7bf3ef646267f08d64 /usr/local/bin/tox-bootstrapd
62d2c7ab2a14d1f9b00acaf13813b3ea916ccfb2173c9ba95ac82a843a258119 /usr/local/bin/tox-bootstrapd
2 changes: 1 addition & 1 deletion toxcore/group_common.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
#define MAX_GC_TOPIC_SIZE 512
#define MAX_GC_GROUP_NAME_SIZE 48
#define GC_MESSAGE_PSEUDO_ID_SIZE 4
#define GROUP_MAX_MESSAGE_LENGTH 1368
#define GROUP_MAX_MESSAGE_LENGTH 1372

/* Max size of a packet chunk. Packets larger than this must be split up.
*
Expand Down
2 changes: 1 addition & 1 deletion toxcore/tox.h
Original file line number Diff line number Diff line change
Expand Up @@ -3301,7 +3301,7 @@ uint32_t tox_group_max_part_length(void);
/**
* Maximum length of a group text message.
*/
#define TOX_GROUP_MAX_MESSAGE_LENGTH 1368
#define TOX_GROUP_MAX_MESSAGE_LENGTH 1372

/**
* Maximum length of a group custom lossy packet.
Expand Down

0 comments on commit 172f279

Please sign in to comment.