Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing ngc constants getter declarations and definitions #2383

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

Green-Sky
Copy link
Member

@Green-Sky Green-Sky commented Jun 10, 2023

This change is Reviewable

@Green-Sky Green-Sky force-pushed the add_ngc_max_size_getters branch 2 times, most recently from c5b137e to 043dc1b Compare June 10, 2023 10:11
@Green-Sky
Copy link
Member Author

should be a simple merge (if the ci plays nice...)
@JFreegman last chance to rename TOX_GROUP_MAX_PASSWORD_SIZE to TOX_GROUP_MAX_PASSWORD_LENGTH

@JFreegman
Copy link
Member

should be a simple merge (if the ci plays nice...) @JFreegman last chance to rename TOX_GROUP_MAX_PASSWORD_SIZE to TOX_GROUP_MAX_PASSWORD_LENGTH

We should make a list of API breaking changes and save them all for the same commit.

Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@Green-Sky
Copy link
Member Author

We should make a list of API breaking changes and save them all for the same commit.

for 0.3.0 ? :)

technically, the ngc api has still not been part of a release yet, so ... we could still change it now.

@JFreegman
Copy link
Member

We should make a list of API breaking changes and save them all for the same commit.

for 0.3.0 ? :)

technically, the ngc api has still not been part of a release yet, so ... we could still change it now.

But it has been part of client releases, which means clients need to make a new release if we break the API

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #2383 (2b1a6b0) into master (2e02d56) will increase coverage by 0.03%.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##           master   #2383      +/-   ##
=========================================
+ Coverage    9.95%   9.98%   +0.03%     
=========================================
  Files         141     141              
  Lines       32503   32530      +27     
=========================================
+ Hits         3235    3249      +14     
- Misses      29268   29281      +13     
Files Changed Coverage Δ
toxcore/tox_test.cc 23.17% <0.00%> (-1.47%) ⬇️
toxcore/tox_api.c 71.28% <100.00%> (+6.22%) ⬆️

... and 5 files with indirect coverage changes

@Green-Sky Green-Sky added this to the v0.2.19 milestone Aug 14, 2023
@iphydf iphydf changed the title FIX: add missing ngc constants getter declarations and definitions fix: add missing ngc constants getter declarations and definitions Aug 14, 2023
@iphydf iphydf merged commit 2b1a6b0 into TokTok:master Aug 14, 2023
33 of 35 checks passed
@Green-Sky Green-Sky deleted the add_ngc_max_size_getters branch November 13, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants