-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Make event dispatch ordered by receive time. #2392
Conversation
8e372bc
to
07f91b7
Compare
|
919e79b
to
beb0ef9
Compare
2436d0d
to
c928ff7
Compare
c928ff7
to
2898df7
Compare
2898df7
to
12bed5c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2392 +/- ##
==========================================
- Coverage 71.11% 66.78% -4.34%
==========================================
Files 127 146 +19
Lines 28517 30279 +1762
==========================================
- Hits 20280 20221 -59
- Misses 8237 10058 +1821 ☔ View full report in Codecov by Sentry. |
12bed5c
to
0834f37
Compare
0834f37
to
1f9ea2f
Compare
ae9a535
to
a230308
Compare
a230308
to
bff4d69
Compare
9681dc9
to
db7ce08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
been running the code in multiple revisions since april last year.
646171e
to
6d63467
Compare
6d63467
to
ad4d240
Compare
f46323e
to
73d9b84
Compare
73d9b84
to
ffa681c
Compare
These are quite expensive, because they go through all events to index in a typed array that no longer exists. Clients should index in the union array and find the event they want themselves, or use dispatch.
ffa681c
to
b4d8826
Compare
This change is