test: Add control flow integrity sanitizer. #2399
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2399 +/- ##
======================================
Coverage 9.99% 9.99%
======================================
Files 141 141
Lines 32530 32530
======================================
+ Hits 3250 3251 +1
+ Misses 29280 29279 -1 ☔ View full report in Codecov by Sentry. |
Green-Sky
reviewed
Sep 1, 2023
CMakeLists.txt
Outdated
| @@ -14,8 +14,8 @@ | |||
| # | |||
| ################################################################################ | |||
|
|
|||
| cmake_minimum_required(VERSION 2.8.12) | |||
| cmake_policy(VERSION 2.8.12) | |||
This will check whether conversions to and casts from `void*` are correct. E.g. `int* -> void* -> float*` will trip the sanitizer. https://clang.llvm.org/docs/ControlFlowIntegrity.html
|
not sure what version of afl++ we are using, but it can also support cfisan |
robinlinden
reviewed
Jan 13, 2024
| @@ -75,6 +75,9 @@ if(APPLE) | |||
| include(MacRpath) | |||
| endif() | |||
|
|
|||
| include(CheckIPOSupported) | |||
| check_ipo_supported() | |||
There was a problem hiding this comment.
Calling this without any arguments makes IPO being unsupported a fatal error. I guess we can either set CMAKE_INTERPROCEDURAL_OPTIMIZATION based on if IPO is supported, or only perform this check if CMAKE_INTERPROCEDURAL_OPTIMIZATION is true.
nurupo
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will check whether conversions to and casts from
void*are correct. E.g.int* -> void* -> float*will trip the sanitizer.https://clang.llvm.org/docs/ControlFlowIntegrity.html
This change is