cleanup: Fix a few more clang-tidy warnings.

[iphydf]

---

This change is 

[nurupo]

It's unnecessary in any of these cases, but having the warning is
useful, and may catch errors in the future.

Which warning? Variable assigned but never used?

[nurupo]

Speaking of warnings, is there a way to make a custom token warning, so that we would get warned if someone uses NULL instead of nullptr?

[iphydf]

Speaking of warnings, is there a way to make a custom token warning, so that we would get warned if someone uses NULL instead of nullptr?

We have that, yes. In one of the builds we get an error for it.

[iphydf]

It's unnecessary in any of these cases, but having the warning is
useful, and may catch errors in the future.

Which warning? Variable assigned but never used?

"Variable not initialised"

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.09% ⚠️

Comparison is base (4d3c97f) 74.57% compared to head (0c5b918) 74.49%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2405      +/-   ##
==========================================
- Coverage   74.57%   74.49%   -0.09%     
==========================================
  Files          87       87              
  Lines       26194    26194              
==========================================
- Hits        19533    19512      -21     
- Misses       6661     6682      +21     

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[iphydf]

I've changed it back. This change conflicts too much with other warnings that are more useful.

[JFreegman]

Reviewed 3 of 87 files at r1, 84 of 84 files at r2, all commit messages.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @nurupo)

[iphydf]

@nurupo PTAL. I've addressed your comments, I think (and also reverted most of it).

[nurupo]

Ah, sorry for the wait, code review replies and @ mentions don't stand out from regular TokTok email spam in my mailbox so I almost missed this, opened it by a pure chance just now.

[nurupo]

LGTM

[nurupo]

code review replies and @ mentions don't stand out from regular TokTok email spam in my mailbox

Actually that's false, they do stand out, was just looking at the wrong gmail label when writing this.