Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Remove redundant -DSODIUM_EXPORT from definitions. #2407

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Aug 31, 2023

-DSODIUM_STATIC implies -DSODIUM_EXPORT.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.13% ⚠️

Comparison is base (0cef46e) 74.66% compared to head (48dbcfe) 74.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2407      +/-   ##
==========================================
- Coverage   74.66%   74.54%   -0.13%     
==========================================
  Files          87       87              
  Lines       26190    26190              
==========================================
- Hits        19555    19523      -32     
- Misses       6635     6667      +32     

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf marked this pull request as ready for review September 11, 2023 12:59
@iphydf iphydf force-pushed the sodium-export branch 2 times, most recently from d1786e3 to 226b379 Compare September 11, 2023 14:47
@iphydf iphydf requested a review from a team as a code owner September 11, 2023 14:47
@iphydf iphydf marked this pull request as draft September 11, 2023 15:06
@iphydf iphydf force-pushed the sodium-export branch 5 times, most recently from 7ea8dca to 9bcf018 Compare September 11, 2023 18:57
`-DSODIUM_STATIC` implies `-DSODIUM_EXPORT`.
@iphydf iphydf marked this pull request as ready for review September 11, 2023 19:49
@toktok-releaser toktok-releaser merged commit 48dbcfe into TokTok:master Sep 11, 2023
37 checks passed
@iphydf iphydf deleted the sodium-export branch September 11, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants